Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Suspicious warnings building on windows (unmappable character (0x90) for encoding windows-1252) #247

Closed
Tracked by #33
dblock opened this issue Oct 26, 2021 · 2 comments
Closed
Tracked by #33

[BUG] Suspicious warnings building on windows (unmappable character (0x90) for encoding windows-1252) #247

dblock opened this issue Oct 26, 2021 · 2 comments
Assignees
@chloe-zh
Labels
bug Something isn't working infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.

Comments

@dblock
Copy link
Member

dblock commented Oct 26, 2021

Describe the bug

Building the plugin on Windows produces suspicious warnings.

To Reproduce

./gradlew build

> Task :legacy:compileJava
C:\Users\Administrator\AppData\Local\Temp\2\tmpovd5v0gr\sql\legacy\src\main\java\org\opensearch\sql\legacy\domain\Condition.java:41: error: unmappable character (0x9D) for encoding windows-1252
 * 过滤�件
          ^
C:\Users\Administrator\AppData\Local\Temp\2\tmpovd5v0gr\sql\legacy\src\main\java\org\opensearch\sql\legacy\domain\Field.java:36: error: unmappable character (0x90) for encoding windows-1252
 * �索域
    ^
C:\Users\Administrator\AppData\Local\Temp\2\tmpovd5v0gr\sql\legacy\src\main\java\org\opensearch\sql\legacy\domain\MethodField.java:37: error: unmappable character (0x90) for encoding windows-1252
 * �索域
    ^
C:\Users\Administrator\AppData\Local\Temp\2\tmpovd5v0gr\sql\legacy\src\main\java\org\opensearch\sql\legacy\domain\Order.java:30: error: unmappable character (0x8F) for encoding windows-1252
 * 排�规�
        ^
C:\Users\Administrator\AppData\Local\Temp\2\tmpovd5v0gr\sql\legacy\src\main\java\org\opensearch\sql\legacy\domain\SearchResult.java:105: error: unmappable character (0x8D) for encoding windows-1252
     * 讲es的field域转�为你Object
                           ^
C:\Users\Administrator\AppData\Local\Temp\2\tmpovd5v0gr\sql\legacy\src\main\java\org\opensearch\sql\legacy\domain\SearchResult.java:124: error: unmappable character (0x8D) for encoding windows-1252
     * 讲es的field域转�为你Object
                           ^
C:\Users\Administrator\AppData\Local\Temp\2\tmpovd5v0gr\sql\legacy\src\main\java\org\opensearch\sql\legacy\domain\Select.java:41: error: unmappable character (0x8F) for encoding windows-1252
 * 将sql语�转�为select 对象
             ^
C:\Users\Administrator\AppData\Local\Temp\2\tmpovd5v0gr\sql\legacy\src\main\java\org\opensearch\sql\legacy\domain\Select.java:41: error: unmappable character (0x8D) for encoding windows-1252
 * 将sql语�转�为select 对象
                   ^
C:\Users\Administrator\AppData\Local\Temp\2\tmpovd5v0gr\sql\legacy\src\main\java\org\opensearch\sql\legacy\parser\FieldMaker.java:64: error: unmappable character (0x8F) for encoding windows-1252
 * 一些具有�数的一�在 select 函数.�者group by 函数
                ^
C:\Users\Administrator\AppData\Local\Temp\2\tmpovd5v0gr\sql\legacy\src\main\java\org\opensearch\sql\legacy\query\maker\AggMaker.java:94: error: unmappable character (0x81) for encoding windows-1252
     * �组查的��函数
                    ^
C:\Users\Administrator\AppData\Local\Temp\2\tmpovd5v0gr\sql\legacy\src\main\java\org\opensearch\sql\legacy\query\maker\AggMaker.java:94: error: unmappable character (0x90) for encoding windows-1252
     * �组查的��函数
                       ^
C:\Users\Administrator\AppData\Local\Temp\2\tmpovd5v0gr\sql\legacy\src\main\java\org\opensearch\sql\legacy\query\maker\Maker.java:116: error: unmappable character (0x9D) for encoding windows-1252
     * 构建过滤�件
                    ^
C:\Users\Administrator\AppData\Local\Temp\2\tmpovd5v0gr\sql\legacy\src\main\java\org\opensearch\sql\legacy\query\maker\QueryMaker.java:42: error: unmappable character (0x9D) for encoding windows-1252
     * 将where�件构建�query
                ^
C:\Users\Administrator\AppData\Local\Temp\2\tmpovd5v0gr\sql\legacy\src\main\java\org\opensearch\sql\legacy\query\maker\QueryMaker.java:42: error: unmappable character (0x90) for encoding windows-1252
     * 将where�件构建�query
                             ^
C:\Users\Administrator\AppData\Local\Temp\2\tmpovd5v0gr\sql\legacy\src\main\java\org\opensearch\sql\legacy\query\maker\QueryMaker.java:81: error: unmappable character (0x8F) for encoding windows-1252
     * 增加嵌套�
                    ^

Host/Environment (please complete the following information):
MINGW64_NT-10.0-17763 EC2AMAZ-4PA8CKB 3.1.7-340.x86_64 2021-10-12 16:29 UTC x86_64 Msys

Additional context
Coming from opensearch-project/opensearch-build#33
@dblock dblock added bug Something isn't working Beta untriaged labels Oct 26, 2021
@dblock dblock mentioned this issue Oct 26, 2021
Closed
19 tasks
@anirudha anirudha assigned chloe-zh and unassigned chloe-zh Oct 28, 2021
@anirudha
Copy link
Collaborator

When not setting the compiler encoding option explicitly, the problem you can run into is, that the Java compiler uses a different file encoding. we should edit the build gradle to set correct compiler encodings

@dai-chen dai-chen added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Dec 14, 2022
Yury-Fridlyand pushed a commit that referenced this issue Mar 21, 2023
@matthewryanwells
Added missing integration tests for the pow and power functions (#247) (
a35f963 
#1457)

* Changed pow and power to return null when an invalid response would be returned and added missing integration tests for the pow and power function.

Signed-off-by: Matthew Wells <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Mar 21, 2023
@matthewryanwells @github-actions
Added missing integration tests for the pow and power functions (#247) (
c973902 
#1457)

* Changed pow and power to return null when an invalid response would be returned and added missing integration tests for the pow and power function.

Signed-off-by: Matthew Wells <[email protected]>
(cherry picked from commit a35f963)
Yury-Fridlyand pushed a commit that referenced this issue Mar 22, 2023
@opensearch-trigger-bot @matthewryanwells
Added missing integration tests for the pow and power functions (#247) (
49a82ae 
#1457) (#1459)

* Changed pow and power to return null when an invalid response would be returned and added missing integration tests for the pow and power function.

Signed-off-by: Matthew Wells <[email protected]>
(cherry picked from commit a35f963)

Co-authored-by: Matthew Wells <[email protected]>
@Yury-Fridlyand
Copy link
Collaborator

Fixed by #1365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chloe-zh chloe-zh

Labels
bug Something isn't working infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
No open projects
SQL Engineering
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@anirudha @dblock @chloe-zh @dai-chen @Yury-Fridlyand