Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed error with single timestamp filter query on prometheus datasource #1244

Merged
merged 1 commit into from
Jan 7, 2023
Merged

Fixed error with single timestamp filter query on prometheus datasource #1244

merged 1 commit into from
Jan 7, 2023

Conversation

vmmusings
Copy link
Member

@vmmusings vmmusings commented Jan 7, 2023 •
edited
Loading

Signed-off-by: vamsi-amazon [email protected]

Description

Fix Below Bug: #1243

Issues Resolved

#1243

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vmmusings vmmusings linked an issue Jan 7, 2023 that may be closed by this pull request
[BUG] Select query on prometheus with only timestamp filter is throwing error. #1243
Closed
@vmmusings vmmusings self-assigned this Jan 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2023 •
edited by codecov bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.88%. Comparing base (aae57a0) to head (9bfd5c7).
Report is 458 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #1244      +/-   ##
============================================
- Coverage     98.34%   95.88%   -2.46%     
- Complexity     3584     3585       +1     
============================================
  Files           344      354      +10     
  Lines          8858     9517     +659     
  Branches        559      679     +120     
============================================
+ Hits           8711     9125     +414     
- Misses          142      334     +192     
- Partials          5       58      +53
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@vmmusings vmmusings changed the title Fixed error with single timestamp query Fixed error with single timestamp filter query on prometheus datasource Jan 7, 2023
@ps48 ps48 mentioned this pull request Jan 7, 2023
Closed
@vmmusings vmmusings marked this pull request as ready for review January 7, 2023 01:28
@vmmusings vmmusings requested a review from a team as a code owner January 7, 2023 01:28
anirudha
anirudha approved these changes Jan 7, 2023
View reviewed changes
Copy link
Collaborator

@anirudha anirudha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vmmusings vmmusings merged commit ee949cc into opensearch-project:main Jan 7, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 7, 2023
@vmmusings @github-actions
Fixed error with single timestamp query (#1244)
489c13b 
Signed-off-by: vamsi-amazon <[email protected]>

Signed-off-by: vamsi-amazon <[email protected]>
(cherry picked from commit ee949cc)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 7, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 7, 2023
@vmmusings @github-actions
Fixed error with single timestamp query (#1244)
0e5767e 
Signed-off-by: vamsi-amazon <[email protected]>

Signed-off-by: vamsi-amazon <[email protected]>
(cherry picked from commit ee949cc)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 7, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 9, 2023
@vmmusings @github-actions
Fixed error with single timestamp query (#1244)
5c50d47 
Signed-off-by: vamsi-amazon <[email protected]>

Signed-off-by: vamsi-amazon <[email protected]>
(cherry picked from commit ee949cc)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 9, 2023
Merged
vmmusings added a commit that referenced this pull request Jan 9, 2023
@opensearch-trigger-bot @vmmusings
Fixed error with single timestamp query (#1244) (#1246)
2a10671 
Signed-off-by: vamsi-amazon <[email protected]>

Signed-off-by: vamsi-amazon <[email protected]>
(cherry picked from commit ee949cc)

Co-authored-by: vamsi-amazon <[email protected]>
@dai-chen dai-chen added the bug Something isn't working label Jan 9, 2023
vmmusings added a commit that referenced this pull request Jan 9, 2023
@opensearch-trigger-bot @vmmusings
Fixed error with single timestamp query (#1244) (#1249)
0a37306 
Signed-off-by: vamsi-amazon <[email protected]>

Signed-off-by: vamsi-amazon <[email protected]>
(cherry picked from commit ee949cc)

Co-authored-by: vamsi-amazon <[email protected]>
penghuo added a commit that referenced this pull request Jan 10, 2023
@penghuo @zelinh
@GabeFernandez310 @YANG-DB @opensearch-trigger-bot @vmmusings @Yury-Fridlyand @dai-chen @joshuali925
Merge pull request #1260 from penghuo/hp/2.5-release
72a3867 
* Add BWC tests for running against distribution bundle.  (#1209)

Signed-off-by: Zelin Hao <[email protected]>

* Add Alternate Syntax For Match_Query And Other Functions (#1166)

Added Tests And Implementation For Match_Query, Match_Phrase, and Multi_Match Functions

Signed-off-by: GabeFernandez310 <[email protected]>

Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>

* Merge pull request #1241 from Bit-Quill/Failing-CI-Hot-Fix

Hot Fix For CI Build

(cherry picked from commit aae57a0)
Signed-off-by: GabeFernandez310 <[email protected]>

* Fixed error with single timestamp query (#1244) (#1246)

Signed-off-by: vamsi-amazon <[email protected]>

Signed-off-by: vamsi-amazon <[email protected]>
(cherry picked from commit ee949cc)

Co-authored-by: vamsi-amazon <[email protected]>

* Add Second_Of_Minute Function As An Alias Of The Second Function (#1231) (#1237)

Added Testing And Implementation For Second_Of_Minute Function

Signed-off-by: GabeFernandez310 <[email protected]>

Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit dce7d0e)

Co-authored-by: GabeFernandez310 <[email protected]>

* Add functions `ADDTIME` and `SUBTIME`. (#132) (#1194) (#1252)

* Add functions `ADDTIME` and `SUBTIME`. (#132)

Signed-off-by: Yury-Fridlyand <[email protected]>
(cherry picked from commit 7630f87)

Co-authored-by: Yury-Fridlyand <[email protected]>

* Add Day_Of_Week Function As An Alias Of DayOfWeek (#190) (#1228) (#1239)

Added Implementation And Testing For Day_Of_Week Function

Signed-off-by: GabeFernandez310 <[email protected]>

Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit bac9c37)

Co-authored-by: GabeFernandez310 <[email protected]>

* [Backport 2.x] Add Minute_Of_Hour Function As An Alias Of Minute Function (#1253)

* Add Minute_Of_Hour Function As An Alias Of Minute Function (#196) (#1230)

Added Testing And Implementation For Minute_Of_Hour Function

Signed-off-by: GabeFernandez310 <[email protected]>

Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 61e2374)

* Added Missing Imports

Signed-off-by: GabeFernandez310 <[email protected]>

Signed-off-by: GabeFernandez310 <[email protected]>

* Add support for long value return for CEIL, CEILING and FLOOR math functions (#1205) (#1255)

* Added long fix for CEIL, CEILING and FLOOR functions using LONG instead of INT for RETURN.

Signed-off-by: MitchellGale-BitQuill <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>

* Support JOIN query on object field with unexpanded name (#1229) (#1250)

* Resolve sub object field in search hit source

Signed-off-by: Chen Dai <[email protected]>

* Rename to unexpanded object

Signed-off-by: Chen Dai <[email protected]>

* Update IT with where condition

Signed-off-by: Chen Dai <[email protected]>

* Fix test index mapping

Signed-off-by: Chen Dai <[email protected]>

Signed-off-by: Chen Dai <[email protected]>
(cherry picked from commit 151f4cc)

Co-authored-by: Chen Dai <[email protected]>

* Remove unnecessary scripts after repo split (#1256)

Signed-off-by: Joshua Li <[email protected]>

* Add Support For `TIME` Type in "*_OF_YEAR" Functions (#199) (#1223) (#1258)

Added Support And Tests For Time Type in day_of_year, week_of_year, month_of_year Functions
Signed-off-by: GabeFernandez310 <[email protected]>
(cherry picked from commit 6e72f18)

Co-authored-by: GabeFernandez310 <[email protected]>

Signed-off-by: Zelin Hao <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: GabeFernandez310 <[email protected]>
Signed-off-by: MitchellGale-BitQuill <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Co-authored-by: Zelin Hao <[email protected]>
Co-authored-by: GabeFernandez310 <[email protected]>
Co-authored-by: YANGDB <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: vamsi-amazon <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
Co-authored-by: GabeFernandez310 <[email protected]>
Co-authored-by: Chen Dai <[email protected]>
Co-authored-by: Joshua Li <[email protected]>
vmmusings added a commit that referenced this pull request Jan 31, 2023
@opensearch-trigger-bot @vmmusings
[Backport 2.4] Fixed error with single timestamp filter query on prom…
c3625b3 
…etheus datasource (#1247)

* Fixed error with single timestamp query (#1244)

Signed-off-by: vamsi-amazon <[email protected]>

Signed-off-by: vamsi-amazon <[email protected]>
(cherry picked from commit ee949cc)

* Fixed test case with compiltation error

Signed-off-by: Vamsi Manohar <[email protected]>

---------

Signed-off-by: Vamsi Manohar <[email protected]>
Co-authored-by: vamsi-amazon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps48 ps48 ps48 approved these changes

@anirudha anirudha anirudha approved these changes

Assignees

@vmmusings vmmusings

Labels
backport 2.x backport 2.4 backport 2.5 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Select query on prometheus with only timestamp filter is throwing error.
5 participants
@vmmusings @codecov-commenter @anirudha @ps48 @dai-chen