-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using jackson and jackson_databind version defined in OpenSearch #1169
Conversation
Signed-off-by: Peng Huo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
build.gradle
Outdated
apply plugin: 'opensearch.java' | ||
// versions https://github.com/opensearch-project/OpenSearch/blob/main/buildSrc/version.properties | ||
ext { | ||
jackson_version = versions.jackson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t we conform to the same version name convention ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not get it. do you mean using version.jackson directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes 👍
Signed-off-by: Peng Huo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1169 +/- ##
=========================================
Coverage 95.81% 95.81%
Complexity 3521 3521
=========================================
Files 352 352
Lines 9359 9359
Branches 673 673
=========================================
Hits 8967 8967
Misses 334 334
Partials 58 58
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-1169-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5073215f813bad5fdad0d5d37a20c7cb100296fd
# Push it to GitHub
git push --set-upstream origin backport/backport-1169-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-1169-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5073215f813bad5fdad0d5d37a20c7cb100296fd
# Push it to GitHub
git push --set-upstream origin backport/backport-1169-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.0 2.0
# Navigate to the new working tree
cd .worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-1169-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5073215f813bad5fdad0d5d37a20c7cb100296fd
# Push it to GitHub
git push --set-upstream origin backport/backport-1169-to-2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.0 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.1 2.1
# Navigate to the new working tree
cd .worktrees/backport-2.1
# Create a new branch
git switch --create backport/backport-1169-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5073215f813bad5fdad0d5d37a20c7cb100296fd
# Push it to GitHub
git push --set-upstream origin backport/backport-1169-to-2.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.1 Then, create a pull request where the |
Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit 5073215)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.2 2.2
# Navigate to the new working tree
cd .worktrees/backport-2.2
# Create a new branch
git switch --create backport/backport-1169-to-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5073215f813bad5fdad0d5d37a20c7cb100296fd
# Push it to GitHub
git push --set-upstream origin backport/backport-1169-to-2.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.2 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.4 2.4
# Navigate to the new working tree
cd .worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-1169-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5073215f813bad5fdad0d5d37a20c7cb100296fd
# Push it to GitHub
git push --set-upstream origin backport/backport-1169-to-2.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.4 Then, create a pull request where the |
…) (#1173) Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit 5073215) Co-authored-by: Peng Huo <[email protected]>
…nsearch-project#1169) Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit 5073215)
…nsearch-project#1169) Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit 5073215)
…) (#1178) Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit 5073215)
…) (#1179) Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit 5073215)
…nsearch-project#1169) (opensearch-project#1178) Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit 5073215)
…nsearch-project#1169) (opensearch-project#1178) Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit 5073215)
…nsearch-project#1169) (opensearch-project#1178) Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit 5073215)
…nsearch-project#1169) (opensearch-project#1178) Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit 5073215)
…) (#1178) (#1185) Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit 5073215)
…) (#1178) (#1186) Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit 5073215)
…) (#1178) (#1184) Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit 5073215)
Signed-off-by: Peng Huo [email protected]
Description
Using jackson and jackson_databind version defined in OpenSearch. SQL plugins's jackson depedency will automatically allign with OpenSearch core then.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.