Add support for distinct aggregation #100
Assignees
Labels
Comments
dai-chen
added
enhancement
|
There may be limitation when there are more than one COUNT(DISTINCT) and they cannot be pushed down to OpenSearch aggregation API together. As I recall, it is translated to JOIN in other database such as MS SQL Server. |
chloe-zh
added a commit
to chloe-zh/opensearch-sql
that referenced
this issue
Jun 9, 2021
…-project#100 Signed-off-by: chloe-zh <[email protected]>
chloe-zh
added a commit
to chloe-zh/opensearch-sql
that referenced
this issue
Jun 9, 2021
…-project#100 Signed-off-by: chloe-zh <[email protected]> # Conflicts: # opensearch/src/main/java/org/opensearch/sql/opensearch/storage/script/aggregation/dsl/MetricAggregationBuilder.java
chloe-zh
added a commit
to chloe-zh/opensearch-sql
that referenced
this issue
Jun 11, 2021
…-project#100 Signed-off-by: chloe-zh <[email protected]> # Conflicts: # core/src/main/java/org/opensearch/sql/expression/DSL.java # core/src/main/java/org/opensearch/sql/expression/aggregation/NamedAggregator.java # core/src/test/java/org/opensearch/sql/analysis/ExpressionAnalyzerTest.java # docs/user/dql/aggregations.rst # integ-test/src/test/resources/correctness/queries/aggregation.txt # opensearch/src/main/java/org/opensearch/sql/opensearch/storage/script/aggregation/dsl/MetricAggregationBuilder.java # opensearch/src/test/java/org/opensearch/sql/opensearch/storage/script/aggregation/dsl/MetricAggregationBuilderTest.java # sql/src/test/java/org/opensearch/sql/sql/parser/AstExpressionBuilderTest.java
chloe-zh
added a commit
to chloe-zh/opensearch-sql
that referenced
this issue
Jul 23, 2021
…oject#100 Signed-off-by: chloe-zh <[email protected]> # Conflicts: # core/src/main/java/org/opensearch/sql/expression/DSL.java # core/src/main/java/org/opensearch/sql/expression/aggregation/NamedAggregator.java # core/src/test/java/org/opensearch/sql/analysis/ExpressionAnalyzerTest.java # docs/user/dql/aggregations.rst # integ-test/src/test/java/org/opensearch/sql/sql/AggregationIT.java # integ-test/src/test/resources/correctness/queries/aggregation.txt # opensearch/src/main/java/org/opensearch/sql/opensearch/storage/script/aggregation/dsl/MetricAggregationBuilder.java # opensearch/src/test/java/org/opensearch/sql/opensearch/storage/script/aggregation/dsl/MetricAggregationBuilderTest.java # sql/src/test/java/org/opensearch/sql/sql/parser/AstExpressionBuilderTest.java
chloe-zh
added a commit
that referenced
this issue
Jul 29, 2021
* Support construct AggregationResponseParser during Aggregator build stage (#108) * Support construct AggregationResponseParser during Aggregator build stage * modify the doc Signed-off-by: penghuo <[email protected]> * support distinct count aggregation Signed-off-by: chloe-zh <[email protected]> * fixed tests Signed-off-by: chloe-zh <[email protected]> * Merge remote-tracking branch 'upstream/develop' into issue/#100 Signed-off-by: chloe-zh <[email protected]> # Conflicts: # opensearch/src/main/java/org/opensearch/sql/opensearch/storage/script/aggregation/dsl/MetricAggregationBuilder.java * update Signed-off-by: chloe-zh <[email protected]> * updated user doc Signed-off-by: chloe-zh <[email protected]> * Update: support only count for distinct aggregations Signed-off-by: chloe-zh <[email protected]> * Update doc; removed distinct start Signed-off-by: chloe-zh <[email protected]> * Removed unnecessary methods Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * Impl stddev and variance function in SQL and PPL (#115) * impl variance frontend and backend * Support construct AggregationResponseParser during Aggregator build stage * add var and varp for PPL Signed-off-by: penghuo <[email protected]> * add UT Signed-off-by: penghuo <[email protected]> * fix UT Signed-off-by: penghuo <[email protected]> * fix doc format Signed-off-by: penghuo <[email protected]> * fix doc format Signed-off-by: penghuo <[email protected]> * fix the doc Signed-off-by: penghuo <[email protected]> * add stddev_samp and stddev_pop Signed-off-by: penghuo <[email protected]> * fix UT coverage * address comments Signed-off-by: penghuo <[email protected]> * Fix the aggregation filter missing in named aggregators (#123) * Take the condition expression as property to the named aggregator when wrapping the delegated aggregator Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * Added test case where filtered agg is not pushed down Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * modified comparison test Signed-off-by: chloe-zh <[email protected]> * removed a comparison test and added it to aggregationIT Signed-off-by: chloe-zh <[email protected]> * added ppl IT test cases; added window function test cases Signed-off-by: chloe-zh <[email protected]> * moved distinct window function test cases to WindowsIT Signed-off-by: chloe-zh <[email protected]> * added ut Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * addressed comments Signed-off-by: chloe-zh <[email protected]> * added test cases to meet the coverage requirement Signed-off-by: chloe-zh <[email protected]> * added test cases for distinct count map and array types Signed-off-by: chloe-zh <[email protected]> Co-authored-by: Peng Huo <[email protected]>
davidcui1225
added a commit
that referenced
this issue
Sep 20, 2021
* Add sql integTest script for opensearch Signed-off-by: Peter Zhu <[email protected]> * Refactor readme (#148) Signed-off-by: Chen Dai <[email protected]> * Build against OpenSearch 1.0.0 and bump artifact version to 1.0.0.0 (#146) * Bump OpenSearch version from rc1 to 1.0.0 Signed-off-by: Chen Dai <[email protected]> * Rename JDBC artifact by removing -rc1 Signed-off-by: Chen Dai <[email protected]> * Remove rc1 qualifier in build workflow Signed-off-by: Chen Dai <[email protected]> * Remove rc1 from build tools version Signed-off-by: Chen Dai <[email protected]> * Fix IT failure Signed-off-by: Chen Dai <[email protected]> * Rollback build tools to rc1 due to known issue Signed-off-by: Chen Dai <[email protected]> * Bump CLI version Signed-off-by: Chen Dai <[email protected]> * Bump query workbench version Signed-off-by: Chen Dai <[email protected]> * Build against 1.0.0 Signed-off-by: Chen Dai <[email protected]> * Update release notes drafter Signed-off-by: Chen Dai <[email protected]> * Update nodejs to 10.24.1 Signed-off-by: Chen Dai <[email protected]> * Change grammar and add UT (#150) Signed-off-by: Chen Dai <[email protected]> * Add release notes for OpenSearch GA (#151) * Add release notes Signed-off-by: Chen Dai <[email protected]> * Change release date Signed-off-by: Chen Dai <[email protected]> * Add bug fixes section Signed-off-by: Chen Dai <[email protected]> * Add sql dashboards tests for workbench Signed-off-by: Peter Zhu <[email protected]> * [1] Fixed aws init and shutdown behaviour (#163) * Support implicit type conversion from string to boolean (#166) * Support implicit type conversion for bool and string Signed-off-by: Chen Dai <[email protected]> * Fix lucene query pushdown issue Signed-off-by: Chen Dai <[email protected]> * Refactor lucene query methods Signed-off-by: Chen Dai <[email protected]> * Refactor builtin repo methods Signed-off-by: Chen Dai <[email protected]> * Add comparison test Signed-off-by: Chen Dai <[email protected]> * Fix comparison test Signed-off-by: Chen Dai <[email protected]> * Add doc test for user manual Signed-off-by: Chen Dai <[email protected]> * Fix doc test Signed-off-by: Chen Dai <[email protected]> * Fix design doc link Signed-off-by: Chen Dai <[email protected]> * Fix RST render issue Signed-off-by: Chen Dai <[email protected]> * Fix cast function pushdown issue Signed-off-by: Chen Dai <[email protected]> * Improve javadoc for PR Signed-off-by: Chen Dai <[email protected]> * Upload design doc Signed-off-by: Chen Dai <[email protected]> * Add more user manual Signed-off-by: Chen Dai <[email protected]> * Add more user manual Signed-off-by: Chen Dai <[email protected]> * Fix doctest Signed-off-by: Chen Dai <[email protected]> * Support distinct count aggregation (#167) * Support construct AggregationResponseParser during Aggregator build stage (#108) * Support construct AggregationResponseParser during Aggregator build stage * modify the doc Signed-off-by: penghuo <[email protected]> * support distinct count aggregation Signed-off-by: chloe-zh <[email protected]> * fixed tests Signed-off-by: chloe-zh <[email protected]> * Merge remote-tracking branch 'upstream/develop' into issue/#100 Signed-off-by: chloe-zh <[email protected]> # Conflicts: # opensearch/src/main/java/org/opensearch/sql/opensearch/storage/script/aggregation/dsl/MetricAggregationBuilder.java * update Signed-off-by: chloe-zh <[email protected]> * updated user doc Signed-off-by: chloe-zh <[email protected]> * Update: support only count for distinct aggregations Signed-off-by: chloe-zh <[email protected]> * Update doc; removed distinct start Signed-off-by: chloe-zh <[email protected]> * Removed unnecessary methods Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * Impl stddev and variance function in SQL and PPL (#115) * impl variance frontend and backend * Support construct AggregationResponseParser during Aggregator build stage * add var and varp for PPL Signed-off-by: penghuo <[email protected]> * add UT Signed-off-by: penghuo <[email protected]> * fix UT Signed-off-by: penghuo <[email protected]> * fix doc format Signed-off-by: penghuo <[email protected]> * fix doc format Signed-off-by: penghuo <[email protected]> * fix the doc Signed-off-by: penghuo <[email protected]> * add stddev_samp and stddev_pop Signed-off-by: penghuo <[email protected]> * fix UT coverage * address comments Signed-off-by: penghuo <[email protected]> * Fix the aggregation filter missing in named aggregators (#123) * Take the condition expression as property to the named aggregator when wrapping the delegated aggregator Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * Added test case where filtered agg is not pushed down Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * modified comparison test Signed-off-by: chloe-zh <[email protected]> * removed a comparison test and added it to aggregationIT Signed-off-by: chloe-zh <[email protected]> * added ppl IT test cases; added window function test cases Signed-off-by: chloe-zh <[email protected]> * moved distinct window function test cases to WindowsIT Signed-off-by: chloe-zh <[email protected]> * added ut Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * addressed comments Signed-off-by: chloe-zh <[email protected]> * added test cases to meet the coverage requirement Signed-off-by: chloe-zh <[email protected]> * added test cases for distinct count map and array types Signed-off-by: chloe-zh <[email protected]> Co-authored-by: Peng Huo <[email protected]> * Support implicit type conversion from string to temporal (#171) * Support implicit cast from string to temporal types Signed-off-by: Chen Dai <[email protected]> * Add comparison test Signed-off-by: Chen Dai <[email protected]> * Add doctest Signed-off-by: Chen Dai <[email protected]> * Fix doctest Signed-off-by: Chen Dai <[email protected]> * Add more user manual Signed-off-by: Chen Dai <[email protected]> * Add more user manual Signed-off-by: Chen Dai <[email protected]> * Fix doctest Signed-off-by: Chen Dai <[email protected]> * Update user manual Signed-off-by: Chen Dai <[email protected]> * Use externally-defined OpenSearch version when specified. Signed-off-by: dblock <[email protected]> * Use OpenSearch 1.1 and build snapshot by default. (#181) Signed-off-by: dblock <[email protected]> * Bump path-parse from 1.0.6 to 1.0.7 in /workbench (#178) Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Workbench: auto dump cypress test data, support security (#199) * Workbench: remove curl commands in integtest.sh (#200) Signed-off-by: Joshua Li <[email protected]> * Fix import path for cypress constant (#201) * Bump version to 1.1 for Opensearch 1.1.0.0 release (#202) * bump workbench versions to 1.1 Signed-off-by: David Cui <[email protected]> * bump version to 1.1.0.0 for 1.1 release Signed-off-by: David Cui <[email protected]> * add release notes for 1.1 Signed-off-by: David Cui <[email protected]> * bump odbc files to 1.1.0.0 Signed-off-by: David Cui <[email protected]> * Bump opensearch ref to 1.1 in CI (#205) * Fix PPL request concurrency handling issue (#207) * Downscope request to local method Signed-off-by: Chen Dai <[email protected]> * Fix checkstyle Signed-off-by: Chen Dai <[email protected]> * Removed integtest.sh. (#208) Signed-off-by: dblock <[email protected]> Co-authored-by: Peter Zhu <[email protected]> Co-authored-by: Chen Dai <[email protected]> Co-authored-by: Lyndon Bauto <[email protected]> Co-authored-by: Chloe <[email protected]> Co-authored-by: Peng Huo <[email protected]> Co-authored-by: dblock <[email protected]> Co-authored-by: Daniel Doubrovkine (dB.) <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joshua <[email protected]>
vmmusings
added a commit
that referenced
this issue
Mar 9, 2022
* Add sql integTest script for opensearch Signed-off-by: Peter Zhu <[email protected]> * Refactor readme (#148) Signed-off-by: Chen Dai <[email protected]> * Build against OpenSearch 1.0.0 and bump artifact version to 1.0.0.0 (#146) * Bump OpenSearch version from rc1 to 1.0.0 Signed-off-by: Chen Dai <[email protected]> * Rename JDBC artifact by removing -rc1 Signed-off-by: Chen Dai <[email protected]> * Remove rc1 qualifier in build workflow Signed-off-by: Chen Dai <[email protected]> * Remove rc1 from build tools version Signed-off-by: Chen Dai <[email protected]> * Fix IT failure Signed-off-by: Chen Dai <[email protected]> * Rollback build tools to rc1 due to known issue Signed-off-by: Chen Dai <[email protected]> * Bump CLI version Signed-off-by: Chen Dai <[email protected]> * Bump query workbench version Signed-off-by: Chen Dai <[email protected]> * Build against 1.0.0 Signed-off-by: Chen Dai <[email protected]> * Update release notes drafter Signed-off-by: Chen Dai <[email protected]> * Update nodejs to 10.24.1 Signed-off-by: Chen Dai <[email protected]> * Change grammar and add UT (#150) Signed-off-by: Chen Dai <[email protected]> * Add release notes for OpenSearch GA (#151) * Add release notes Signed-off-by: Chen Dai <[email protected]> * Change release date Signed-off-by: Chen Dai <[email protected]> * Add bug fixes section Signed-off-by: Chen Dai <[email protected]> * Add sql dashboards tests for workbench Signed-off-by: Peter Zhu <[email protected]> * [1] Fixed aws init and shutdown behaviour (#163) * Support implicit type conversion from string to boolean (#166) * Support implicit type conversion for bool and string Signed-off-by: Chen Dai <[email protected]> * Fix lucene query pushdown issue Signed-off-by: Chen Dai <[email protected]> * Refactor lucene query methods Signed-off-by: Chen Dai <[email protected]> * Refactor builtin repo methods Signed-off-by: Chen Dai <[email protected]> * Add comparison test Signed-off-by: Chen Dai <[email protected]> * Fix comparison test Signed-off-by: Chen Dai <[email protected]> * Add doc test for user manual Signed-off-by: Chen Dai <[email protected]> * Fix doc test Signed-off-by: Chen Dai <[email protected]> * Fix design doc link Signed-off-by: Chen Dai <[email protected]> * Fix RST render issue Signed-off-by: Chen Dai <[email protected]> * Fix cast function pushdown issue Signed-off-by: Chen Dai <[email protected]> * Improve javadoc for PR Signed-off-by: Chen Dai <[email protected]> * Upload design doc Signed-off-by: Chen Dai <[email protected]> * Add more user manual Signed-off-by: Chen Dai <[email protected]> * Add more user manual Signed-off-by: Chen Dai <[email protected]> * Fix doctest Signed-off-by: Chen Dai <[email protected]> * Support distinct count aggregation (#167) * Support construct AggregationResponseParser during Aggregator build stage (#108) * Support construct AggregationResponseParser during Aggregator build stage * modify the doc Signed-off-by: penghuo <[email protected]> * support distinct count aggregation Signed-off-by: chloe-zh <[email protected]> * fixed tests Signed-off-by: chloe-zh <[email protected]> * Merge remote-tracking branch 'upstream/develop' into issue/#100 Signed-off-by: chloe-zh <[email protected]> # Conflicts: # opensearch/src/main/java/org/opensearch/sql/opensearch/storage/script/aggregation/dsl/MetricAggregationBuilder.java * update Signed-off-by: chloe-zh <[email protected]> * updated user doc Signed-off-by: chloe-zh <[email protected]> * Update: support only count for distinct aggregations Signed-off-by: chloe-zh <[email protected]> * Update doc; removed distinct start Signed-off-by: chloe-zh <[email protected]> * Removed unnecessary methods Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * Impl stddev and variance function in SQL and PPL (#115) * impl variance frontend and backend * Support construct AggregationResponseParser during Aggregator build stage * add var and varp for PPL Signed-off-by: penghuo <[email protected]> * add UT Signed-off-by: penghuo <[email protected]> * fix UT Signed-off-by: penghuo <[email protected]> * fix doc format Signed-off-by: penghuo <[email protected]> * fix doc format Signed-off-by: penghuo <[email protected]> * fix the doc Signed-off-by: penghuo <[email protected]> * add stddev_samp and stddev_pop Signed-off-by: penghuo <[email protected]> * fix UT coverage * address comments Signed-off-by: penghuo <[email protected]> * Fix the aggregation filter missing in named aggregators (#123) * Take the condition expression as property to the named aggregator when wrapping the delegated aggregator Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * Added test case where filtered agg is not pushed down Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * modified comparison test Signed-off-by: chloe-zh <[email protected]> * removed a comparison test and added it to aggregationIT Signed-off-by: chloe-zh <[email protected]> * added ppl IT test cases; added window function test cases Signed-off-by: chloe-zh <[email protected]> * moved distinct window function test cases to WindowsIT Signed-off-by: chloe-zh <[email protected]> * added ut Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * addressed comments Signed-off-by: chloe-zh <[email protected]> * added test cases to meet the coverage requirement Signed-off-by: chloe-zh <[email protected]> * added test cases for distinct count map and array types Signed-off-by: chloe-zh <[email protected]> Co-authored-by: Peng Huo <[email protected]> * Support implicit type conversion from string to temporal (#171) * Support implicit cast from string to temporal types Signed-off-by: Chen Dai <[email protected]> * Add comparison test Signed-off-by: Chen Dai <[email protected]> * Add doctest Signed-off-by: Chen Dai <[email protected]> * Fix doctest Signed-off-by: Chen Dai <[email protected]> * Add more user manual Signed-off-by: Chen Dai <[email protected]> * Add more user manual Signed-off-by: Chen Dai <[email protected]> * Fix doctest Signed-off-by: Chen Dai <[email protected]> * Update user manual Signed-off-by: Chen Dai <[email protected]> * Use externally-defined OpenSearch version when specified. Signed-off-by: dblock <[email protected]> * Use OpenSearch 1.1 and build snapshot by default. (#181) Signed-off-by: dblock <[email protected]> * Bump path-parse from 1.0.6 to 1.0.7 in /workbench (#178) Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Workbench: auto dump cypress test data, support security (#199) * Workbench: remove curl commands in integtest.sh (#200) Signed-off-by: Joshua Li <[email protected]> * Fix import path for cypress constant (#201) * Bump version to 1.1 for Opensearch 1.1.0.0 release (#202) * bump workbench versions to 1.1 Signed-off-by: David Cui <[email protected]> * bump version to 1.1.0.0 for 1.1 release Signed-off-by: David Cui <[email protected]> * add release notes for 1.1 Signed-off-by: David Cui <[email protected]> * bump odbc files to 1.1.0.0 Signed-off-by: David Cui <[email protected]> * Bump opensearch ref to 1.1 in CI (#205) * Fix PPL request concurrency handling issue (#207) * Downscope request to local method Signed-off-by: Chen Dai <[email protected]> * Fix checkstyle Signed-off-by: Chen Dai <[email protected]> * Removed integtest.sh. (#208) Signed-off-by: dblock <[email protected]> * Support match function as filter in SQL and PPL (#204) * supported match in sql and ppl where Signed-off-by: chloe-zh <[email protected]> * added legacy syntax in new parser Signed-off-by: chloe-zh <[email protected]> * added integration test Signed-off-by: chloe-zh <[email protected]> * updated user manual Signed-off-by: chloe-zh <[email protected]> * updated user manual Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * added ppl integ test, updated ppl manual Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * Changed the ODBC mac installer build platform to MacOS 10.15 from latest (#230) Signed-off-by: chloe-zh <[email protected]> * Renamed plugin helper config file to consistent name with OSD (#228) * Update build to use public Maven repo (#225) * Update build to use public Maven repo Signed-off-by: Abbas Hussain <[email protected]> * Update runner to use macos-11 for odbc builds Signed-off-by: Abbas Hussain <[email protected]> * Address security vulnerability CVE-2021-3795 (#231) Signed-off-by: chloe-zh <[email protected]> * Addressed security vulnerability CVE-2021-3807 (#233) * Support ODBC compatibility with ODFE SQL (#238) * compatible with opensearch and all versions in odfe with sql plugin Signed-off-by: chloe-zh <[email protected]> * address comments Signed-off-by: chloe-zh <[email protected]> * Support span aggregation in query engine (#220) * Added span in ppl; push down only Signed-off-by: chloe-zh <[email protected]> * refined span return type Signed-off-by: chloe-zh <[email protected]> * added unit test cases for span aggregation builder and parser Signed-off-by: chloe-zh <[email protected]> * implemented in memory execution of span aggregation Signed-off-by: chloe-zh <[email protected]> * checkstyle Signed-off-by: chloe-zh <[email protected]> * enabled alias Signed-off-by: chloe-zh <[email protected]> * added integration test Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * added unit test cases for span aggregation builder and parser Signed-off-by: chloe-zh <[email protected]> * Updated PPL user manual Signed-off-by: chloe-zh <[email protected]> * Enable DCO Workflow Check (#242) * enable dco check Signed-off-by: chloe-zh <[email protected]> * updated contribution doc Signed-off-by: chloe-zh <[email protected]> * Bump version to 1.1.0.1 for patch release (#253) * Bump version to 1.1.0.1 for patch release Signed-off-by: chloe-zh <[email protected]> * Removed redundant line Signed-off-by: chloe-zh <[email protected]> * Add new protocol for visualization response format (#251) * added viz protocol, added tests and updated user manual Signed-off-by: chloe-zh <[email protected]> * changed version back to 1.1 Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * Bumps version to 1.2 (#254) * Updates dashbquery-workbench-dashboardsoards version to 1.2. Changes the package jsons, as well as the github action workflows. Signed-off-by: Tengda He <[email protected]> * bump version to 1.2 changes Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * fix broken link Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * Remove unnecessary stubs Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: Joshua Li <[email protected]> * 1.2 release notes Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * 1.2 release notes Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * Update notice files (#269) Signed-off-by: Joshua Li <[email protected]> * Add support for datetime type conversion in JDBC Signed-off-by: Guian Gumpac <[email protected]> * Optimized type converting in DSL filters (#272) * optimized cast in filter queries Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * added unit tests Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * Update license headers for /**/ style files Signed-off-by: Joshua Li <[email protected]> * Fix and add more license headers Signed-off-by: Joshua Li <[email protected]> * Add gradlew Signed-off-by: Joshua Li <[email protected]> * Remove amazon license in # and /**/ comment style files Signed-off-by: Joshua Li <[email protected]> * Remove amazon license in other files Signed-off-by: Joshua Li <[email protected]> * Remove for one more file Signed-off-by: Joshua Li <[email protected]> * Add some missing licenses Signed-off-by: Joshua Li <[email protected]> * Updated PPL user manual with relevance function limitations (#283) * update user manual on relevanc function limitations Signed-off-by: chloe-zh <[email protected]> * update Signed-off-by: chloe-zh <[email protected]> * Update release notes for 1.2 release (#289) Signed-off-by: Joshua Li <[email protected]> * Added Tableau Connector to OpenSearch SQL (#290) Signed-off-by: Guian Gumpac <[email protected]> * Fixed result parsing error for boolean type (#284) Signed-off-by: chloe-zh <[email protected]> * Fixed StringIndexOutOfBoundsException issue of left and right text functions (#285) Signed-off-by: chloe-zh <[email protected]> * Add support for codeowners to repo (#286) Signed-off-by: Ryan Bogan <[email protected]> * use opensearch-py client (#306) * use opensearch-py client Signed-off-by: Zhongnan Su <[email protected]> * reformat code Signed-off-by: Zhongnan Su <[email protected]> * fix doctest Signed-off-by: Zhongnan Su <[email protected]> * Fix query string handling for workbench (#305) * fix line break handling for ppl Signed-off-by: Joshua Li <[email protected]> * escape quotes in query requests Signed-off-by: Joshua Li <[email protected]> * [sql-cli] wrap error response into exception (#309) Signed-off-by: Zhongnan Su <[email protected]> * added new badges, fixed links Signed-off-by: Shenoy Pratik <[email protected]> * added codecov for workbench Signed-off-by: Shenoy Pratik <[email protected]> * updated codecov flags Signed-off-by: Shenoy Pratik <[email protected]> * renamed workbench flag Signed-off-by: Shenoy Pratik <[email protected]> * updated IT link Signed-off-by: Shenoy Pratik <[email protected]> * updated header name Signed-off-by: Shenoy Pratik <[email protected]> * updated workbench header Signed-off-by: Shenoy Pratik <[email protected]> * updated link checker Signed-off-by: Shenoy Pratik <[email protected]> * Fixed issue #291 and updated the dialect for Tableau Connector (#296) * Added Tableau Connector to OpenSearch SQL Signed-off-by: Guian Gumpac <[email protected]> * Added CEILING and FLOOR functions Signed-off-by: Guian Gumpac <[email protected]> * Added IFNULL function Signed-off-by: Guian Gumpac <[email protected]> * Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null Signed-off-by: Guian Gumpac <[email protected]> * Added MIN and MAX for two string arguments Signed-off-by: Guian Gumpac <[email protected]> * Fixed return type for MID function redefenitions, part of AOS-202 Signed-off-by: Yury Fridlyand <[email protected]> * Added CAST functions to convert to int or string as part of AOS-202 Signed-off-by: Yury Fridlyand <[email protected]> * Added HEXBINX and HEXBINY functions from the templace without any modifications Signed-off-by: Yury Fridlyand <[email protected]> * Fixed cast to use the OSSQL type Signed-off-by: Yury Fridlyand <[email protected]> * Added parenthesis to avoid opensearch-project/sql/issues/293 Signed-off-by: Yury Fridlyand <[email protected]> * Modified Timestamp conversion formula Signed-off-by: Guian Gumpac <[email protected]> * Added comment to TimestampType Signed-off-by: Guian Gumpac <[email protected]> * Updated Company Name accroding to the customer's request Signed-off-by: Yury Fridlyand <[email protected]> * Updated Vendor Name as well Signed-off-by: Yury Fridlyand <[email protected]> Co-authored-by: Yury Fridlyand <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> * Type conversion (#318) * Added Tableau Connector to OpenSearch SQL Signed-off-by: Guian Gumpac <[email protected]> * Added CEILING and FLOOR functions Signed-off-by: Guian Gumpac <[email protected]> * Added IFNULL function Signed-off-by: Guian Gumpac <[email protected]> * Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null Signed-off-by: Guian Gumpac <[email protected]> * Added MIN and MAX for two string arguments Signed-off-by: Guian Gumpac <[email protected]> * Fixed return type for MID function redefenitions, part of AOS-202 Signed-off-by: Yury Fridlyand <[email protected]> * Added CAST functions to convert to int or string as part of AOS-202 Signed-off-by: Yury Fridlyand <[email protected]> * Added HEXBINX and HEXBINY functions from the templace without any modifications Signed-off-by: Yury Fridlyand <[email protected]> * Fixed cast to use the OSSQL type Signed-off-by: Yury Fridlyand <[email protected]> * Added parenthesis to avoid opensearch-project/sql/issues/293 Signed-off-by: Yury Fridlyand <[email protected]> * Modified Timestamp conversion formula Signed-off-by: Guian Gumpac <[email protected]> * Added comment to TimestampType Signed-off-by: Guian Gumpac <[email protected]> * Updated Company Name accroding to the customer's request Signed-off-by: Yury Fridlyand <[email protected]> * Updated Vendor Name as well Signed-off-by: Yury Fridlyand <[email protected]> * Modified the driver to recognize its support for conversion of types Signed-off-by: Guian Gumpac <[email protected]> * Removed changes from a different branch Signed-off-by: Guian Gumpac <[email protected]> * Removed changes from a different branch Signed-off-by: Guian Gumpac <[email protected]> * Made the connector convert keyword columns to string columns Signed-off-by: Guian Gumpac <[email protected]> * Modified integration tests to reflect support for conversion types Signed-off-by: Guian Gumpac <[email protected]> * Removed connector changes Signed-off-by: Guian Gumpac <[email protected]> * Change values to bitmasks Signed-off-by: Guian Gumpac <[email protected]> * Removed jdbc changes from previous commits Signed-off-by: Guian Gumpac <[email protected]> * Removed jdbc changes from previous commits Signed-off-by: Guian Gumpac <[email protected]> * Removed jdbc changes from previous commits Signed-off-by: Guian Gumpac <[email protected]> Co-authored-by: Yury Fridlyand <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> * Updated pbi connector (#320) * Added Tableau Connector to OpenSearch SQL Signed-off-by: Guian Gumpac <[email protected]> * Added CEILING and FLOOR functions Signed-off-by: Guian Gumpac <[email protected]> * Added IFNULL function Signed-off-by: Guian Gumpac <[email protected]> * Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null Signed-off-by: Guian Gumpac <[email protected]> * Added MIN and MAX for two string arguments Signed-off-by: Guian Gumpac <[email protected]> * Fixed return type for MID function redefenitions, part of AOS-202 Signed-off-by: Yury Fridlyand <[email protected]> * Added CAST functions to convert to int or string as part of AOS-202 Signed-off-by: Yury Fridlyand <[email protected]> * Added HEXBINX and HEXBINY functions from the templace without any modifications Signed-off-by: Yury Fridlyand <[email protected]> * Fixed cast to use the OSSQL type Signed-off-by: Yury Fridlyand <[email protected]> * Added parenthesis to avoid opensearch-project/sql/issues/293 Signed-off-by: Yury Fridlyand <[email protected]> * Modified Timestamp conversion formula Signed-off-by: Guian Gumpac <[email protected]> * Added comment to TimestampType Signed-off-by: Guian Gumpac <[email protected]> * Updated Company Name accroding to the customer's request Signed-off-by: Yury Fridlyand <[email protected]> * Updated Vendor Name as well Signed-off-by: Yury Fridlyand <[email protected]> * Added few small changes to simplify connector developing and debugging Signed-off-by: Yury Fridlyand <[email protected]> * Typo fix Signed-off-by: Yury Fridlyand <[email protected]> * Added a simple test from TDVT: case bool0 from test calcs_data (an expression test) Some mofidication were made in the test framework to make the output more readable Signed-off-by: Yury Fridlyand <[email protected]> * Modified the driver to recognize its support for conversion of types Signed-off-by: Guian Gumpac <[email protected]> * Removed changes from a different branch Signed-off-by: Guian Gumpac <[email protected]> * Removed changes from a different branch Signed-off-by: Guian Gumpac <[email protected]> * Made the connector convert keyword columns to string columns Signed-off-by: Guian Gumpac <[email protected]> * Fix requested by PR review Signed-off-by: Yury Fridlyand <[email protected]> * Modified integration tests to reflect support for conversion types Signed-off-by: Guian Gumpac <[email protected]> * Removed connector changes Signed-off-by: Guian Gumpac <[email protected]> * Change values to bitmasks Signed-off-by: Guian Gumpac <[email protected]> * Remove changes from irrelevant commits Signed-off-by: Guian Gumpac <[email protected]> * Remove changes from irrelevant commits Signed-off-by: Guian Gumpac <[email protected]> * Updated the mez file Signed-off-by: Guian Gumpac <[email protected]> Co-authored-by: Yury Fridlyand <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> * Add integTestRemote for sql (#327) * Add integTestRemote for sql Signed-off-by: Joshua Li <[email protected]> * Remove unused comment Signed-off-by: Joshua Li <[email protected]> * Bump log4j to 2.15 and bump plugin to 1.2.1 (#324) * Fix merge conflicts Signed-off-by: Joshua Li <[email protected]> * Update release notes Signed-off-by: Joshua Li <[email protected]> * Revert version bump for workbench Signed-off-by: Joshua Li <[email protected]> * Update headers (#323) * Update headers Signed-off-by: Lyndon Bauto <[email protected]> * [1] Updating installer Signed-off-by: Lyndon Bauto <[email protected]> Co-authored-by: Joshua Li <[email protected]> * Add backwards compatibility tests for SQL (#322) * Add bwc tests setup Signed-off-by: Joshua Li <[email protected]> * update setup Signed-off-by: Joshua Li <[email protected]> * Use only 1 cluster Signed-off-by: Joshua Li <[email protected]> * Use 2 clusters Signed-off-by: Joshua Li <[email protected]> * Add 1.2 snapshot Signed-off-by: Joshua Li <[email protected]> * Fix test setup Signed-off-by: Joshua Li <[email protected]> * Add sql bwc tests for queries and cluster settings Signed-off-by: Joshua Li <[email protected]> * Add bwc test script and remove latest artifact Signed-off-by: Joshua Li <[email protected]> * Format code Signed-off-by: Joshua Li <[email protected]> * Fix indentation Signed-off-by: Joshua Li <[email protected]> * Add bwc tests to CI Signed-off-by: Joshua Li <[email protected]> * Bump bwc to 1.2.1-SNAPSHOT Signed-off-by: Joshua Li <[email protected]> * Bump log4j to 2.16 and plugin to 1.2.2 (#338) * Bump log4j to 2.16 and plugin to 1.2.2 Signed-off-by: Joshua Li <[email protected]> * Add release notes Signed-off-by: Joshua Li <[email protected]> * Bump bwc to 1.2.2-SNAPSHOT Signed-off-by: Joshua Li <[email protected]> * Use opensearch_version for bwc Signed-off-by: Joshua Li <[email protected]> * added untriaged and nolabel badges Signed-off-by: Shenoy Pratik <[email protected]> * backporting log4j to main Signed-off-by: Shenoy Pratik <[email protected]> * Bump sql main to 1.3.0 (#351) Signed-off-by: Joshua Li <[email protected]> * Update docs links for workbench (#352) Signed-off-by: Joshua Li <[email protected]> * Upgrade to log4j 2.17.1. (#354) Signed-off-by: dblock <[email protected]> * Driver timestamp (#333) * Added Tableau Connector to OpenSearch SQL Signed-off-by: Guian Gumpac <[email protected]> * Added CEILING and FLOOR functions Signed-off-by: Guian Gumpac <[email protected]> * Added IFNULL function Signed-off-by: Guian Gumpac <[email protected]> * Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null Signed-off-by: Guian Gumpac <[email protected]> * Added MIN and MAX for two string arguments Signed-off-by: Guian Gumpac <[email protected]> * Fixed return type for MID function redefenitions, part of AOS-202 Signed-off-by: Yury Fridlyand <[email protected]> * Added CAST functions to convert to int or string as part of AOS-202 Signed-off-by: Yury Fridlyand <[email protected]> * Added HEXBINX and HEXBINY functions from the templace without any modifications Signed-off-by: Yury Fridlyand <[email protected]> * Fixed cast to use the OSSQL type Signed-off-by: Yury Fridlyand <[email protected]> * Added parenthesis to avoid opensearch-project/sql/issues/293 Signed-off-by: Yury Fridlyand <[email protected]> * Modified Timestamp conversion formula Signed-off-by: Guian Gumpac <[email protected]> * Added comment to TimestampType Signed-off-by: Guian Gumpac <[email protected]> * Updated Company Name accroding to the customer's request Signed-off-by: Yury Fridlyand <[email protected]> * Updated Vendor Name as well Signed-off-by: Yury Fridlyand <[email protected]> * Added few small changes to simplify connector developing and debugging Signed-off-by: Yury Fridlyand <[email protected]> * Typo fix Signed-off-by: Yury Fridlyand <[email protected]> * Added a simple test from TDVT: case bool0 from test calcs_data (an expression test) Some mofidication were made in the test framework to make the output more readable Signed-off-by: Yury Fridlyand <[email protected]> * Modified the driver to recognize its support for conversion of types Signed-off-by: Guian Gumpac <[email protected]> * Removed changes from a different branch Signed-off-by: Guian Gumpac <[email protected]> * Removed changes from a different branch Signed-off-by: Guian Gumpac <[email protected]> * Made the connector convert keyword columns to string columns Signed-off-by: Guian Gumpac <[email protected]> * Fix requested by PR review Signed-off-by: Yury Fridlyand <[email protected]> * Modified integration tests to reflect support for conversion types Signed-off-by: Guian Gumpac <[email protected]> * Removed connector changes Signed-off-by: Guian Gumpac <[email protected]> * Change values to bitmasks Signed-off-by: Guian Gumpac <[email protected]> * Add timestamp as a type for the driver Signed-off-by: Guian Gumpac <[email protected]> * Added timestamp to SQLGetTypeInfo for the ODBC Driver Signed-off-by: Guian Gumpac <[email protected]> * Reverted some previous changes Signed-off-by: Guian Gumpac <[email protected]> * Removed generated test output file Signed-off-by: Guian Gumpac <[email protected]> Co-authored-by: Yury Fridlyand <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> * Add .whitesource configuration file * Add TDVT test report for the Tableau JDBC connector (#355) * Added Tableau Connector to OpenSearch SQL Signed-off-by: Guian Gumpac <[email protected]> * Added CEILING and FLOOR functions Signed-off-by: Guian Gumpac <[email protected]> * Added IFNULL function Signed-off-by: Guian Gumpac <[email protected]> * Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null Signed-off-by: Guian Gumpac <[email protected]> * Added MIN and MAX for two string arguments Signed-off-by: Guian Gumpac <[email protected]> * Fixed return type for MID function redefenitions, part of AOS-202 Signed-off-by: Yury Fridlyand <[email protected]> * Added CAST functions to convert to int or string as part of AOS-202 Signed-off-by: Yury Fridlyand <[email protected]> * Added HEXBINX and HEXBINY functions from the templace without any modifications Signed-off-by: Yury Fridlyand <[email protected]> * Fixed cast to use the OSSQL type Signed-off-by: Yury Fridlyand <[email protected]> * Added parenthesis to avoid opensearch-project/sql/issues/293 Signed-off-by: Yury Fridlyand <[email protected]> * Modified Timestamp conversion formula Signed-off-by: Guian Gumpac <[email protected]> * Added comment to TimestampType Signed-off-by: Guian Gumpac <[email protected]> * Updated Company Name accroding to the customer's request Signed-off-by: Yury Fridlyand <[email protected]> * Updated Vendor Name as well Signed-off-by: Yury Fridlyand <[email protected]> * Added TDVT test result and a readme file Signed-off-by: Yury Fridlyand <[email protected]> Co-authored-by: Guian Gumpac <[email protected]> Co-authored-by: guiangumpac <[email protected]> * PowerBI certification changes (#349) * Added Tableau Connector to OpenSearch SQL Signed-off-by: Guian Gumpac <[email protected]> * Added CEILING and FLOOR functions Signed-off-by: Guian Gumpac <[email protected]> * Added IFNULL function Signed-off-by: Guian Gumpac <[email protected]> * Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null Signed-off-by: Guian Gumpac <[email protected]> * Added MIN and MAX for two string arguments Signed-off-by: Guian Gumpac <[email protected]> * Fixed return type for MID function redefenitions, part of AOS-202 Signed-off-by: Yury Fridlyand <[email protected]> * Added CAST functions to convert to int or string as part of AOS-202 Signed-off-by: Yury Fridlyand <[email protected]> * Added HEXBINX and HEXBINY functions from the templace without any modifications Signed-off-by: Yury Fridlyand <[email protected]> * Fixed cast to use the OSSQL type Signed-off-by: Yury Fridlyand <[email protected]> * Added parenthesis to avoid opensearch-project/sql/issues/293 Signed-off-by: Yury Fridlyand <[email protected]> * Modified Timestamp conversion formula Signed-off-by: Guian Gumpac <[email protected]> * Added comment to TimestampType Signed-off-by: Guian Gumpac <[email protected]> * Updated Company Name accroding to the customer's request Signed-off-by: Yury Fridlyand <[email protected]> * Updated Vendor Name as well Signed-off-by: Yury Fridlyand <[email protected]> * Added few small changes to simplify connector developing and debugging Signed-off-by: Yury Fridlyand <[email protected]> * Typo fix Signed-off-by: Yury Fridlyand <[email protected]> * Added a simple test from TDVT: case bool0 from test calcs_data (an expression test) Some mofidication were made in the test framework to make the output more readable Signed-off-by: Yury Fridlyand <[email protected]> * Modified the driver to recognize its support for conversion of types Signed-off-by: Guian Gumpac <[email protected]> * Removed changes from a different branch Signed-off-by: Guian Gumpac <[email protected]> * Removed changes from a different branch Signed-off-by: Guian Gumpac <[email protected]> * Made the connector convert keyword columns to string columns Signed-off-by: Guian Gumpac <[email protected]> * Fix requested by PR review Signed-off-by: Yury Fridlyand <[email protected]> * Modified integration tests to reflect support for conversion types Signed-off-by: Guian Gumpac <[email protected]> * Removed connector changes Signed-off-by: Guian Gumpac <[email protected]> * Change values to bitmasks Signed-off-by: Guian Gumpac <[email protected]> * Add timestamp as a type for the driver Signed-off-by: Guian Gumpac <[email protected]> * Added timestamp to SQLGetTypeInfo for the ODBC Driver Signed-off-by: Guian Gumpac <[email protected]> * Reverted some previous changes Signed-off-by: Guian Gumpac <[email protected]> * Removed generated test output file Signed-off-by: Guian Gumpac <[email protected]> * Renamed SqlOdbcPBIConnector to OpenSearch Signed-off-by: Guian Gumpac <[email protected]> * According to AOS-248, we have to build the server address string properly: - add http[s]:// prefix - add port In scope of this task 2 new fields were added to the connection dialog (port, useSSL) and the corresponding handling. Signed-off-by: Yury Fridlyand <[email protected]> * Added version and disable trace output as per Microsoft's feedback Signed-off-by: Guian Gumpac <[email protected]> * Added documentation for the OpenSearch connector Signed-off-by: Guian Gumpac <[email protected]> * Renamed connector markdown file to follow naming conventions Signed-off-by: Guian Gumpac <[email protected]> * Changed image file extention as it was not being detected by GitHub Signed-off-by: Guian Gumpac <[email protected]> * Updating docs according to PR #16 comments. Signed-off-by: Yury Fridlyand <[email protected]> * Added GitHub actions script to build Tableau and Power BI connector. The PBI connector is being built twice with different names accroding to the Amazon's request. Signed-off-by: Yury Fridlyand <[email protected]> * A typo fix in yml Signed-off-by: Yury Fridlyand <[email protected]> * A dummy commit to make GitHub Actions start the desired workflow Signed-off-by: Yury Fridlyand <[email protected]> * Workflow fix - pack Tableau ODBC connector instead of JDBC one Signed-off-by: Yury Fridlyand <[email protected]> * Fix line endings in the workflow file Signed-off-by: Yury Fridlyand <[email protected]> * Another dummy commit to start the desired workflow Signed-off-by: Yury Fridlyand <[email protected]> * Fix paths in the GitHub workflow Signed-off-by: Yury Fridlyand <[email protected]> * Modified workflow to trigger on changes of itself Signed-off-by: Yury Fridlyand <[email protected]> * Path fix for preparation step Signed-off-by: Yury Fridlyand <[email protected]> * Added some changes to the second PBI connector - they should differ more than in filename to make PBI distuingish them Signed-off-by: Yury Fridlyand <[email protected]> * Renamed PBI connector files Signed-off-by: Yury Fridlyand <[email protected]> * Moved Tableau JDBC connector to bi-connectors Signed-off-by: Yury Fridlyand <[email protected]> * Added packing Tableau JDBC connector For all connectors added check for successful packing before publishing Signed-off-by: Yury Fridlyand <[email protected]> * Renamed Power BI connector as "OpenSearch Project" Signed-off-by: Yury Fridlyand <[email protected]> * Renamed output artifact Signed-off-by: Yury Fridlyand <[email protected]> * Update SqlOdbcPBIConnector.pq according to PR review notes Co-authored-by: Kyle Porter <[email protected]> * Update SqlOdbcPBIConnector.pq according to PR review notes Co-authored-by: Kyle Porter <[email protected]> * Modified code that builds the server string Signed-off-by: Yury Fridlyand <[email protected]> * Fixed grammatical errors, added a docs directory, and updated the connection string options image Signed-off-by: Guian Gumpac <[email protected]> * Removed md file as it was moved to the docs directory Signed-off-by: Guian Gumpac <[email protected]> * Fixed grammatical errors and updated the old power bi support document Signed-off-by: Guian Gumpac <[email protected]> * Removed extra line Signed-off-by: Guian Gumpac <[email protected]> * Disabled building Tableau ODBC connector, because it is not ready for shipping Signed-off-by: Yury Fridlyand <[email protected]> * Updated workflow step description Signed-off-by: Yury Fridlyand <[email protected]> * Removed packing ODBC driver for Tableau (re: 4cadfd18). Removed Tableau ODBC driver source files since the driver is not supposed to be. Signed-off-by: Yury Fridlyand <[email protected]> * Updated workflow, because connector source files were renamed after merge Signed-off-by: Yury Fridlyand <[email protected]> * Revert "Add GitHub workflow to pack BI connectors" * Changed string replacement in the main connector file Signed-off-by: Yury Fridlyand <[email protected]> * Script was modified according to PR comments Signed-off-by: Yury Fridlyand <[email protected]> * Removed Tableau ODBC connector Signed-off-by: Yury Fridlyand <[email protected]> * Merged OpenSearch-sql main to this branch and updated links as per the PR comment Signed-off-by: Guian Gumpac <[email protected]> Co-authored-by: Yury Fridlyand <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> Co-authored-by: Kyle Porter <[email protected]> * Support date_nanos OpenSearch field type (#360) * Convert date_nanos to timestamp Signed-off-by: Joshua Li <[email protected]> * Use nano seconds precision for timestamp Signed-off-by: Joshua Li <[email protected]> * Update unit tests Signed-off-by: Joshua Li <[email protected]> * Update docs for date_nanos Signed-off-by: Joshua Li <[email protected]> * Bump gson and json-schema (#370) Signed-off-by: Joshua Li <[email protected]> * Update release notes 1.2.4 Signed-off-by: Shenoy Pratik <[email protected]> * added maintenance section Signed-off-by: Shenoy Pratik <[email protected]> * Remove jcenter in sql and jdbc (#378) Signed-off-by: Joshua Li <[email protected]> * Connector limitation documentation (#366) * Added Tableau Connector to OpenSearch SQL Signed-off-by: Guian Gumpac <[email protected]> * Added CEILING and FLOOR functions Signed-off-by: Guian Gumpac <[email protected]> * Added IFNULL function Signed-off-by: Guian Gumpac <[email protected]> * Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null Signed-off-by: Guian Gumpac <[email protected]> * Added MIN and MAX for two string arguments Signed-off-by: Guian Gumpac <[email protected]> * Fixed return type for MID function redefenitions, part of AOS-202 Signed-off-by: Yury Fridlyand <[email protected]> * Added CAST functions to convert to int or string as part of AOS-202 Signed-off-by: Yury Fridlyand <[email protected]> * Added HEXBINX and HEXBINY functions from the templace without any modifications Signed-off-by: Yury Fridlyand <[email protected]> * Fixed cast to use the OSSQL type Signed-off-by: Yury Fridlyand <[email protected]> * Added parenthesis to avoid opensearch-project/sql/issues/293 Signed-off-by: Yury Fridlyand <[email protected]> * Modified Timestamp conversion formula Signed-off-by: Guian Gumpac <[email protected]> * Added comment to TimestampType Signed-off-by: Guian Gumpac <[email protected]> * Updated Company Name accroding to the customer's request Signed-off-by: Yury Fridlyand <[email protected]> * Updated Vendor Name as well Signed-off-by: Yury Fridlyand <[email protected]> * Added few small changes to simplify connector developing and debugging Signed-off-by: Yury Fridlyand <[email protected]> * Typo fix Signed-off-by: Yury Fridlyand <[email protected]> * Added a simple test from TDVT: case bool0 from test calcs_data (an expression test) Some mofidication were made in the test framework to make the output more readable Signed-off-by: Yury Fridlyand <[email protected]> * Modified the driver to recognize its support for conversion of types Signed-off-by: Guian Gumpac <[email protected]> * Removed changes from a different branch Signed-off-by: Guian Gumpac <[email protected]> * Removed changes from a different branch Signed-off-by: Guian Gumpac <[email protected]> * Made the connector convert keyword columns to string columns Signed-off-by: Guian Gumpac <[email protected]> * Fix requested by PR review Signed-off-by: Yury Fridlyand <[email protected]> * Modified integration tests to reflect support for conversion types Signed-off-by: Guian Gumpac <[email protected]> * Removed connector changes Signed-off-by: Guian Gumpac <[email protected]> * Change values to bitmasks Signed-off-by: Guian Gumpac <[email protected]> * Add timestamp as a type for the driver Signed-off-by: Guian Gumpac <[email protected]> * Added timestamp to SQLGetTypeInfo for the ODBC Driver Signed-off-by: Guian Gumpac <[email protected]> * Reverted some previous changes Signed-off-by: Guian Gumpac <[email protected]> * Removed generated test output file Signed-off-by: Guian Gumpac <[email protected]> * Renamed SqlOdbcPBIConnector to OpenSearch Signed-off-by: Guian Gumpac <[email protected]> * According to AOS-248, we have to build the server address string properly: - add http[s]:// prefix - add port In scope of this task 2 new fields were added to the connection dialog (port, useSSL) and the corresponding handling. Signed-off-by: Yury Fridlyand <[email protected]> * Added version and disable trace output as per Microsoft's feedback Signed-off-by: Guian Gumpac <[email protected]> * Added documentation for the OpenSearch connector Signed-off-by: Guian Gumpac <[email protected]> * Renamed connector markdown file to follow naming conventions Signed-off-by: Guian Gumpac <[email protected]> * Changed image file extention as it was not being detected by GitHub Signed-off-by: Guian Gumpac <[email protected]> * Updating docs according to PR #16 comments. Signed-off-by: Yury Fridlyand <[email protected]> * Added GitHub actions script to build Tableau and Power BI connector. The PBI connector is being built twice with different names accroding to the Amazon's request. Signed-off-by: Yury Fridlyand <[email protected]> * A typo fix in yml Signed-off-by: Yury Fridlyand <[email protected]> * A dummy commit to make GitHub Actions start the desired workflow Signed-off-by: Yury Fridlyand <[email protected]> * Workflow fix - pack Tableau ODBC connector instead of JDBC one Signed-off-by: Yury Fridlyand <[email protected]> * Fix line endings in the workflow file Signed-off-by: Yury Fridlyand <[email protected]> * Another dummy commit to start the desired workflow Signed-off-by: Yury Fridlyand <[email protected]> * Fix paths in the GitHub workflow Signed-off-by: Yury Fridlyand <[email protected]> * Modified workflow to trigger on changes of itself Signed-off-by: Yury Fridlyand <[email protected]> * Path fix for preparation step Signed-off-by: Yury Fridlyand <[email protected]> * Added some changes to the second PBI connector - they should differ more than in filename to make PBI distuingish them Signed-off-by: Yury Fridlyand <[email protected]> * Renamed PBI connector files Signed-off-by: Yury Fridlyand <[email protected]> * Moved Tableau JDBC connector to bi-connectors Signed-off-by: Yury Fridlyand <[email protected]> * Added packing Tableau JDBC connector For all connectors added check for successful packing before publishing Signed-off-by: Yury Fridlyand <[email protected]> * Renamed Power BI connector as "OpenSearch Project" Signed-off-by: Yury Fridlyand <[email protected]> * Renamed output artifact Signed-off-by: Yury Fridlyand <[email protected]> * Update SqlOdbcPBIConnector.pq according to PR review notes Co-authored-by: Kyle Porter <[email protected]> * Update SqlOdbcPBIConnector.pq according to PR review notes Co-authored-by: Kyle Porter <[email protected]> * Modified code that builds the server string Signed-off-by: Yury Fridlyand <[email protected]> * Fixed grammatical errors, added a docs directory, and updated the connection string options image Signed-off-by: Guian Gumpac <[email protected]> * Removed md file as it was moved to the docs directory Signed-off-by: Guian Gumpac <[email protected]> * Fixed grammatical errors and updated the old power bi support document Signed-off-by: Guian Gumpac <[email protected]> * Removed extra line Signed-off-by: Guian Gumpac <[email protected]> * Disabled building Tableau ODBC connector, because it is not ready for shipping Signed-off-by: Yury Fridlyand <[email protected]> * Updated workflow step description Signed-off-by: Yury Fridlyand <[email protected]> * Removed packing ODBC driver for Tableau (re: 4cadfd18). Removed Tableau ODBC driver source files since the driver is not supposed to be. Signed-off-by: Yury Fridlyand <[email protected]> * Updated workflow, because connector source files were renamed after merge Signed-off-by: Yury Fridlyand <[email protected]> * Revert "Add GitHub workflow to pack BI connectors" * Changed string replacement in the main connector file Signed-off-by: Yury Fridlyand <[email protected]> * Script was modified according to PR comments Signed-off-by: Yury Fridlyand <[email protected]> * Added limitations and issues table to connector markdown file Signed-off-by: Guian Gumpac <[email protected]> * Removed Tableau ODBC connector Signed-off-by: Yury Fridlyand <[email protected]> * Merged OpenSearch-sql main to this branch and updated links as per the PR comment Signed-off-by: Guian Gumpac <[email protected]> * Added link to bug Signed-off-by: Guian Gumpac <[email protected]> * Made changes as per requested in the PR comments. Linked github issues to issues listed Signed-off-by: Guian Gumpac <[email protected]> * Added changes to the OpenSearch md file Signed-off-by: Guian Gumpac <[email protected]> * Removed unused images Signed-off-by: Guian Gumpac <[email protected]> Co-authored-by: Yury Fridlyand <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> Co-authored-by: Kyle Porter <[email protected]> * Address msft feedback (#380) * Added Tableau Connector to OpenSearch SQL Signed-off-by: Guian Gumpac <[email protected]> * Added CEILING and FLOOR functions Signed-off-by: Guian Gumpac <[email protected]> * Added IFNULL function Signed-off-by: Guian Gumpac <[email protected]> * Added Kyle's fix for ADDDATE and SUBDATE with resulting 00:00:00 being unexpectedly null Signed-off-by: Guian Gumpac <[email protected]> * Added MIN and MAX for two string arguments Signed-off-by: Guian Gumpac <[email protected]> * Fixed return type for MID function redefenitions, part of AOS-202 Signed-off-by: Yury Fridlyand <[email protected]> * Added CAST functions to convert to int or string as part of AOS-202 Signed-off-by: Yury Fridlyand <[email protected]> * Added HEXBINX and HEXBINY functions from the templace without any modifications Signed-off-by: Yury Fridlyand <[email protected]> * Fixed cast to use the OSSQL type Signed-off-by: Yury Fridlyand <[email protected]> * Added parenthesis to avoid opensearch-project/sql/issues/293 Signed-off-by: Yury Fridlyand <[email protected]> * Modified Timestamp conversion formula Signed-off-by: Guian Gumpac <[email protected]> * Added comment to TimestampType Signed-off-by: Guian Gumpac <[email protected]> * Updated Company Name accroding to the customer's request Signed-off-by: Yury Fridlyand <[email protected]> * Updated Vendor Name as well Signed-off-by: Yury Fridlyand <[email protected]> * Added few small changes to simplify connector developing and debugging Signed-off-by: Yury Fridlyand <[email protected]> * Typo fix Signed-off-by: Yury Fridlyand <[email protected]> * Added a simple test from TDVT: case bool0 from test calcs_data (an expression test) Some mofidication were made in the test framework to make the output more readable Signed-off-by: Yury Fridlyand <[email protected]> * Modified the driver to recognize its support for conversion of types Signed-off-by: Guian Gumpac <[email protected]> * Removed changes from a different branch Signed-off-by: Guian Gumpac <[email protected]> * Removed changes from a different branch Signed-off-by: Guian Gumpac <[email protected]> * Made the connector convert keyword columns to string columns Signed-off-by: Guian Gumpac <[email protected]> * Fix requested by PR review Signed-off-by: Yury Fridlyand <[email protected]> * Modified integration tests to reflect support for conversion types Signed-off-by: Guian Gumpac <[email protected]> * Removed connector changes Signed-off-by: Guian Gumpac <[email protected]> * Change values to bitmasks Signed-off-by: Guian Gumpac <[email protected]> * Add timestamp as a type for the driver Signed-off-by: Guian Gumpac <[email protected]> * Added timestamp to SQLGetTypeInfo for the ODBC Driver Signed-off-by: Guian Gumpac <[email protected]> * Reverted some previous changes Signed-off-by: Guian Gumpac <[email protected]> * Removed generated test output file Signed-off-by: Guian Gumpac <[email protected]> * Renamed SqlOdbcPBIConnector to OpenSearch Signed-off-by: Guian Gumpac <[email protected]> * According to AOS-248, we have to build the server address string properly: - add http[s]:// prefix - add port In scope of this task 2 new fields were added to the connection dialog (port, useSSL) and the corresponding handling. Signed-off-by: Yury Fridlyand <[email protected]> * Added version and disable trace output as per Microsoft's feedback Signed-off-by: Guian Gumpac <[email protected]> * Added documentation for the OpenSearch connector Signed-off-by: Guian Gumpac <[email protected]> * Renamed connector markdown file to follow naming conventions Signed-off-by: Guian Gumpac <[email protected]> * Changed image file extention as it was not being detected by GitHub Signed-off-by: Guian Gumpac <[email protected]> * Updating docs according to PR #16 comments. Signed-off-by: Yury Fridlyand <[email protected]> * Added GitHub actions script to build Tableau and Power BI connector. The PBI connector is being built twice with different names accroding to the Amazon's request. Signed-off-by: Yury Fridlyand <[email protected]> * A typo fix in yml Signed-off-by: Yury Fridlyand <[email protected]> * A dummy commit to make GitHub Actions start the desired workflow Signed-off-by: Yury Fridlyand <[email protected]> * Workflow fix - pack Tableau ODBC connector instead of JDBC one Signed-off-by: Yury Fridlyand <[email protected]> * Fix line endings in the workflow file Signed-off-by: Yury Fridlyand <[email protected]> * Another dummy commit to start the desired workflow Signed-off-by: Yury Fridlyand <[email protected]> * Fix paths in the GitHub workflow Signed-off-by: Yury Fridlyand <[email protected]> * Modified workflow to trigger on changes of itself Signed-off-by: Yury Fridlyand <[email protected]> * Path fix for preparation step Signed-off-by: Yury Fridlyand <[email protected]> * Added some changes to the second PBI connector - they should differ more than in filename to make PBI distuingish them Signed-off-by: Yury Fridlyand <[email protected]> * Renamed PBI connector files Signed-off-by: Yury Fridlyand <[email protected]> * Moved Tableau JDBC connector to bi-connectors Signed-off-by: Yury Fridlyand <[email protected]> * Added packing Tableau JDBC connector For all connectors added check for successful packing before publishing Signed-off-by: Yury Fridlyand <[email protected]> * Renamed Power BI connector as "OpenSearch Project" Signed-off-by: Yury Fridlyand <[email protected]> * Renamed output artifact Signed-off-by: Yury Fridlyand <[email protected]> * Update SqlOdbcPBIConnector.pq according to PR review notes Co-authored-by: Kyle Porter <[email protected]> * Update SqlOdbcPBIConnector.pq according to PR review notes Co-authored-by: Kyle Porter <[email protected]> * Modified code that builds the server string Signed-off-by: Yury Fridlyand <[email protected]> * Fixed grammatical errors, added a docs directory, and updated the connection string options image Signed-off-by: Guian Gumpac <[email protected]> * Removed md file as it was moved to the docs directory Signed-off-by: Guian Gumpac <[email protected]> * Fixed grammatical errors and updated the old power bi support document Signed-off-by: Guian Gumpac <[email protected]> * Removed extra line Signed-off-by: Guian Gumpac <[email protected]> * Disabled building Tableau ODBC connector, because it is not ready for shipping Signed-off-by: Yury Fridlyand <[email protected]> * Updated workflow step description Signed-off-by: Yury Fridlyand <[email protected]> * Removed packing ODBC driver for Tableau (re: 4cadfd18). Removed Tableau ODBC driver source files since the driver is not supposed to be. Signed-off-by: Yury Fridlyand <[email protected]> * Updated workflow, because connector source files were renamed after merge Signed-off-by: Yury Fridlyand <[email protected]> * Revert "Add GitHub workflow to pack BI connectors" * Changed string replacement in the main connector file Signed-off-by: Yury Fridlyand <[email protected]> * Script was modified according to PR comments Signed-off-by: Yury Fridlyand <[email protected]> * Added limitations and issues table to connector markdown file Signed-off-by: Guian Gumpac <[email protected]> * Removed Tableau ODBC connector Signed-off-by: Yury Fridlyand <[email protected]> * Merged OpenSearch-sql main to this branch and updated links as per the PR comment Signed-off-by: Guian Gumpac <[email protected]> * Added link to bug Signed-off-by: Guian Gumpac <[email protected]> * Made changes as per requested in the PR comments. Linked github issues to issues listed Signed-off-by: Guian Gumpac <[email protected]> * Added changes to the OpenSearch md file Signed-off-by: Guian Gumpac <[email protected]> * Modified the connector and workflows to address Power BI certification feedback Signed-off-by: Guian Gumpac <[email protected]> * Changed m filename to AmazonOpenSearchService-ODBC Signed-off-by: Guian Gumpac <[email protected]> * Made further changes to address PBI feedback Signed-off-by: Guian Gumpac <[email protected]> * Fixed github workflow Signed-off-by: Yury Fridlyand <[email protected]> * Modified output filenames of connector workflow Signed-off-by: Guian Gumpac <[email protected]> * Fix workflow Signed-off-by: Yury Fridlyand <[email protected]> * Typo fix in the fix Signed-off-by: Yury Fridlyand <[email protected]> * Changed function prefixes to match connector name Signed-off-by: Guian Gumpac <[email protected]> * Changed DSR Handler Friendly name for Amazon OpenSearch Service connector as requested by the PBI feedback Signed-off-by: Guian Gumpac <[email protected]> * Removed -ODBC suffix as per code review comments Signed-off-by: Guian Gumpac <[email protected]> * Made workflow more concise and changed a variable name Signed-off-by: Guian Gumpac <[email protected]> * Removed irrelevant images Signed-off-by: Guian Gumpac <[email protected]> Co-authored-by: Yury Fridlyand <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> Co-authored-by: Kyle Porter <[email protected]> * Update the README file and and a link to the iODBC (#365) - add a link to the iODBC Driver Manager so it is easier to navigate and install the driver manger Signed-off-by: Alina (Xi) Li <alinalbitquilltech.com> * [SQL-CLI] set version number to 1.0.0 (#381) * Set release version number to 1.0.0 Signed-off-by: Zhongnan Su <[email protected]> * Rewrite span as composite aggregation. (#386) 1.rewrite span as composite aggregation instead of DateHistogram or Histogram aggregation. 2.fix issue #385. Signed-off-by: penghuo <[email protected]> * Rename `opensearch-sql-cli` to `opensearch-sqlcli` to unblock release (#388) * rename the package to opensearch-sqlcli Signed-off-by: Zhongnan Su <[email protected]> * update guava package to 31.0.1-jre (#390) Signed-off-by: Shenoy Pratik <[email protected]> * rename package name of sql-cli from `opensearch-sqlcli` to `opensearchsql` (#392) * rename sql-cli to opensearchsql Signed-off-by: Zhongnan Su <[email protected]> * update workflow Signed-off-by: Zhongnan Su <[email protected]> * Parse none type field as null instead of throw exception (#406) Signed-off-by: penghuo <[email protected]> * Add how to setup aws credentials for ODBC Tableau (#394) Signed-off-by: Joshua Li <[email protected]> * Jackson-databind bump to 2.12.6 (#410) * bumping jackson-databind to 2.12.6 Signed-off-by: Shenoy Pratik <[email protected]> * bumping jackson-core & dataformat-cbor Signed-off-by: Shenoy Pratik <[email protected]> * updated missed gradle files Signed-off-by: Shenoy Pratik <[email protected]> * updated junit & added resolutions Signed-off-by: Shenoy Pratik <[email protected]> * Bug Fix, disable html escape when formatting response (#412) Signed-off-by: penghuo <[email protected]> * Support multiple indices in PPL and SQL (#408) Signed-off-by: penghuo <[email protected]> * Revert to windows 2019 for odbc CI (#413) Signed-off-by: Joshua Li <[email protected]> * Support combination of group field and span in stats command (#417) * Support combination of group field and span in stats command Signed-off-by: penghuo <[email protected]> * Support In clause in SQL and PPL (#420) Signed-off-by: penghuo <[email protected]> * Add cast function to PPL (#433) Signed-off-by: Joshua Li <[email protected]> * Version bump to 1.3 (#419) Signed-off-by: Eugene Lee <[email protected]> * Span expression should always be first in by list if exist (#437) Signed-off-by: penghuo <[email protected]> * Add auto backport functionality for SQL (#445) Add auto backport workflow and documentation. Signed-off-by: David Cui <[email protected]> * Update backport and add auto-delete workflows (#446) * update backport workflow and add auto delete Signed-off-by: David Cui <[email protected]> * Version Bump: springframework and jackson (#443) Signed-off-by: penghuo <[email protected]> * Version Bump: H2 1.x -> 2.x (#444) Signed-off-by: penghuo <[email protected]> * Add CI Matrix for JDK 11 and 14 (#451) Add default version as JDK 11 and add CI matrix for JDK 11 and 14 Signed-off-by: David Cui <[email protected]> * Add Certificate Validation option (#449) Signed-off-by: Guian Gumpac <[email protected]> Signed-off-by: Yury Fridlyand <[email protected]> Co-authored-by: Yury Fridlyand <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> * Treating ExpressionEvaluationException as client Error (#459) Fixed https://github.com/opensearch-project/sql/issues/423. * Add parse command to PPL (#411) Signed-off-by: Joshua Li <[email protected]> * Add limitation section in PPL docs (#456) Signed-off-by: penghuo <[email protected]> * [Enhancement] optimize sort rewrite logic (#434) Optimize sort rewrite logic by using first and last parameter in Composite aggregation. Signed-off-by: penghuo <[email protected]> * Support ISO 8601 Format in Date Format. (#460) Support ISO 8601 (%y-%m-%dT%TZ) in Date Formats. In order to do that we have started supporting plain characters in date format without a % in front. Co-authored-by: Peter Zhu <[email protected]> Co-authored-by: Chen Dai <[email protected]> Co-authored-by: Lyndon Bauto <[email protected]> Co-authored-by: Chloe <[email protected]> Co-authored-by: Peng Huo <[email protected]> Co-authored-by: dblock <[email protected]> Co-authored-by: Daniel Doubrovkine (dB.) <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joshua <[email protected]> Co-authored-by: David Cui <[email protected]> Co-authored-by: Abbas Hussain <[email protected]> Co-authored-by: Tengda-He <[email protected]> Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: guiangumpac <[email protected]> Co-authored-by: Anirudha (Ani) Jadhav <[email protected]> Co-authored-by: Ryan Bogan <[email protected]> Co-authored-by: Zhongnan Su <[email protected]> C…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
Add support for the following aggregations. Note that
COUNT(DISTINCT)is highest priority and others are optional. MySQL reference: https://dev.mysql.com/doc/refman/8.0/en/aggregate-functions.html#function_countPPL may also needs to support count distinct. Reference: https://docs.splunk.com/Documentation/SCS/current/SearchReference/Aggregatefunctions#distinct_count.28.26lt.3Bvalue.26gt.3B.29_or_dc.28.26lt.3Bvalue.26gt.3B.29
Describe alternatives you've considered
N/A
The text was updated successfully, but these errors were encountered: