Fix ASCII function and groom UT for text functions. (#301) (#1895)

* Fix `ASCII` function and groom UT for text functions. * Code cleanup. --------- Signed-off-by: Yury-Fridlyand <[email protected]> (cherry picked from commit 6055c7e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-project · Aug 23, 2023 · df864cb · df864cb
1 parent 3c8e3bd
commit df864cb
Show file tree

Hide file tree

Showing 2 changed files with 95 additions and 212 deletions.
diff --git a/core/src/main/java/org/opensearch/sql/expression/text/TextFunction.java b/core/src/main/java/org/opensearch/sql/expression/text/TextFunction.java
@@ -416,7 +416,8 @@ private static ExprValue exprLeft(ExprValue expr, ExprValue length) {
   }
 
   private static ExprValue exprAscii(ExprValue expr) {
-    return new ExprIntegerValue((int) expr.stringValue().charAt(0));
+    return new ExprIntegerValue(
+        expr.stringValue().length() == 0 ? 0 : (int) expr.stringValue().charAt(0));
   }
 
   private static ExprValue exprLocate(ExprValue subStr, ExprValue str) {