Address PR comment

Signed-off-by: Rupal Mahajan <[email protected]>
opensearch-project · Jul 5, 2023 · be15dae · be15dae
1 parent 0eb5e53
commit be15dae
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/spark/src/main/java/org/opensearch/sql/spark/storage/SparkStorageEngine.java b/spark/src/main/java/org/opensearch/sql/spark/storage/SparkStorageEngine.java
@@ -30,6 +30,6 @@ public Collection<FunctionResolver> getFunctions() {
 
   @Override
   public Table getTable(DataSourceSchemaName dataSourceSchemaName, String tableName) {
-    return null;
+    throw new RuntimeException("Unable to get table from storage engine.");
   }
 }
diff --git a/spark/src/test/java/org/opensearch/sql/spark/storage/SparkStorageEngineTest.java b/spark/src/test/java/org/opensearch/sql/spark/storage/SparkStorageEngineTest.java
@@ -8,6 +8,7 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.util.Collection;
@@ -40,7 +41,8 @@ public void getFunctions() {
   @Test
   public void getTable() {
     SparkStorageEngine engine = new SparkStorageEngine(client);
-    Table table = engine.getTable(new DataSourceSchemaName("spark", "default"), "");
-    assertNull(table);
+    RuntimeException exception = assertThrows(RuntimeException.class,
+        () -> engine.getTable(new DataSourceSchemaName("spark", "default"), ""));
+    assertEquals("Unable to get table from storage engine.", exception.getMessage());
   }
 }