Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding delete system index tests from a security enabled cluster #223

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

joshpalis
Copy link
Member

Description

Excludes integration test classes that attempt to delete system indices from running when security is enabled and adds security tests to CI

Issues Resolved

Forward port of #222

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…adding security test workflow for CI

Signed-off-by: Joshua Palis <[email protected]>
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6dd8a10) 81.69% compared to head (23b2b09) 81.69%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #223   +/-   ##
=========================================
  Coverage     81.69%   81.69%           
  Complexity      206      206           
=========================================
  Files            13       13           
  Lines          1060     1060           
  Branches        141      141           
=========================================
  Hits            866      866           
  Misses          140      140           
  Partials         54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owaiskazi19 owaiskazi19 merged commit 499528f into opensearch-project:main Feb 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants