TenantInfo API should also check backend roles apart from just users … #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #770 +/- ##
============================================
- Coverage 64.47% 64.46% -0.01%
Complexity 3224 3224
============================================
Files 244 244
Lines 17160 17168 +8
Branches 3040 3044 +4
============================================
+ Hits 11064 11068 +4
- Misses 4555 4556 +1
- Partials 1541 1544 +3
Continue to review full report at Codecov.
|
cliu123
reviewed
Oct 16, 2020
| response = rh.executeGetRequest("_opendistro/_security/tenantinfo"); | ||
| Assert.assertEquals(HttpStatus.SC_OK, response.getStatusCode()); | ||
|
|
||
| rh.sendAdminCertificate = true; |
There was a problem hiding this comment.
Why use admin certificate for users but not for backend role?
There was a problem hiding this comment.
It depend upon the test we are performing.
If we want to send credentials with request, we use it, else no
debjanibnrj
reviewed
Oct 19, 2020
| } else if (roleMapping instanceof RoleMappingsV7) { | ||
| backendRoles = ((RoleMappingsV7) roleMapping).getBackend_roles(); | ||
| } | ||
| return backendRoles != null && backendRoles.contains(user.getName()); |
There was a problem hiding this comment.
Won't this be backendRoles.contains(kibanaOpendistroRole) ?
gaobinlong
pushed a commit
to gaobinlong/security
that referenced
this pull request
Aug 30, 2023
gaobinlong
pushed a commit
to gaobinlong/security
that referenced
this pull request
Aug 30, 2023
…arch-project#771) * Create release notes for rc-1 * Bump plugin version to 1.0.0.0-rc1 * Add PR#763, opensearch-project#771 and opensearch-project#770 to release notes rc1 * Build security backend rc1 * change the version in release notes * Change plugin version to rc1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TenantInfo API should also check backend roles apart from just users in rolesmapping
Unit test added
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.