Add Tenants REST API test and partial fix #4166 #4465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willyborankin
requested review from
cliu123,
cwperks,
DarshitChanpura,
peternied,
RyanL1997,
stephen-crawford and
reta
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4465 +/- ##
==========================================
- Coverage 65.27% 65.27% -0.01%
==========================================
Files 313 313
Lines 22057 22058 +1
Branches 3563 3563
==========================================
Hits 14398 14398
- Misses 5888 5889 +1
Partials 1771 1771
|
shikharj05
reviewed
Jun 17, 2024
src/main/java/org/opensearch/security/dlic/rest/api/TenantsApiAction.java
Show resolved
Hide resolved
DarshitChanpura
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Changes look good to me. @willyborankin would you please check why is code-cov complaining?
shikharj05
approved these changes
Jun 19, 2024
Signed-off-by: Andrey Pleskach <[email protected]>
willyborankin
force-pushed
the
refactor-tests#8
branch
from
21ec60b to
aa932f5
Compare
Well codecov/patch shows wrong info about |
reta
approved these changes
Jun 20, 2024
3 tasks
willyborankin
merged commit 1f5bd36
into
opensearch-project:main
41 of 42 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
Signed-off-by: Andrey Pleskach <[email protected]> (cherry picked from commit 1f5bd36) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Tenants REST API test
Issues Resolved
partial fix #4166
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.