Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests #4329

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

willyborankin
Copy link
Collaborator

@willyborankin willyborankin commented May 7, 2024

Description

Fixed flaky integration tests, which were introduced in #4255. The node counter was defined as a global variable, as result it counted more nodes then an actual local cluster had.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andrey Pleskach <[email protected]>
@willyborankin willyborankin added the backport 2.x backport to 2.x branch label May 8, 2024
@reta reta merged commit bac93dc into opensearch-project:main May 8, 2024
78 of 79 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 8, 2024
Signed-off-by: Andrey Pleskach <[email protected]>
(cherry picked from commit bac93dc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@willyborankin willyborankin deleted the fix-flaky-tests branch June 14, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants