Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space between definitions in gradle build #4304

Merged
merged 1 commit into from
May 6, 2024

Conversation

willyborankin
Copy link
Collaborator

@willyborankin willyborankin commented Apr 29, 2024

Description

Added space between common_utils version and
java libs versions (kafka_version, open_saml_version etc.) n the gradle.build file.
in the buildscript ext section to avoid falires for auto backport to the 2.x branch

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Added space between `common_utils` version and
java libs versions (`kafka_version`, `open_saml_version` etc.)
in the `buildscript` `ext` section to avoid falires for auto backport to the 2.x branch

Signed-off-by: Andrey Pleskach <[email protected]>
@willyborankin willyborankin changed the title Add space between definitions Add space between definitions in gradle build Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.11%. Comparing base (6d35a0a) to head (c6ab057).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4304      +/-   ##
==========================================
- Coverage   66.12%   66.11%   -0.01%     
==========================================
  Files         302      302              
  Lines       21758    21758              
  Branches     3522     3522              
==========================================
- Hits        14387    14385       -2     
- Misses       5609     5610       +1     
- Partials     1762     1763       +1     

see 3 files with indirect coverage changes

Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this PR. Can you point to the failure where this issue occurs?

@cwperks cwperks merged commit 5c18a36 into opensearch-project:main May 6, 2024
81 of 82 checks passed
@willyborankin willyborankin deleted the gradle-build-fix branch June 14, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants