Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Allow TransportConfigUpdateAction when security config initialization has completed (#3810) #3927

Merged

Conversation

peternied
Copy link
Member

Description

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… initialization has completed (opensearch-project#3810)

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Co-authored-by: Peter Nied <[email protected]>
Co-authored-by: Peter Nied <[email protected]>
(cherry picked from commit 045d4ef)
Signed-off-by: Peter Nied <[email protected]>
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (8eaa2e0) 65.03% compared to head (9bbe84a) 65.07%.
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #3927      +/-   ##
==========================================
+ Coverage   65.03%   65.07%   +0.04%     
==========================================
  Files         297      297              
  Lines       20995    21026      +31     
  Branches     3439     3444       +5     
==========================================
+ Hits        13654    13683      +29     
+ Misses       5636     5635       -1     
- Partials     1705     1708       +3     
Files Coverage Δ
.../opensearch/security/OpenSearchSecurityPlugin.java 84.58% <100.00%> (+0.13%) ⬆️
...ensearch/security/auditlog/config/AuditConfig.java 99.22% <100.00%> (+0.05%) ⬆️
...earch/security/auditlog/impl/AbstractAuditLog.java 76.20% <ø> (ø)
...pensearch/security/auditlog/impl/AuditMessage.java 75.00% <100.00%> (+0.24%) ⬆️
...ch/security/securityconf/DynamicConfigFactory.java 54.85% <ø> (ø)
...g/opensearch/security/support/ConfigConstants.java 95.23% <ø> (ø)
...tion/configupdate/TransportConfigUpdateAction.java 95.45% <66.66%> (-4.55%) ⬇️
...ecurity/configuration/ConfigurationRepository.java 71.57% <71.08%> (+0.92%) ⬆️

... and 1 file with indirect coverage changes

willyborankin
willyborankin previously approved these changes Jan 6, 2024
Signed-off-by: Peter Nied <[email protected]>
@cwperks cwperks merged commit f58e99d into opensearch-project:2.x Jan 8, 2024
@peternied peternied deleted the backport/backport-3810-to-2.x branch January 9, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants