Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add deprecation check for jwt_header setting #3896

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 3c566a4 from #3887.

### Description
Add deprecation check for `jwt_header` setting

### Issues Resolved
- Related #3886

### Check List
- [ ] ~New functionality includes testing~
- [ ] New functionality has been documented
- [X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Peter Nied <[email protected]>
(cherry picked from commit 3c566a4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (02881cd) 65.03% compared to head (21d14e0) 65.07%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #3896      +/-   ##
============================================
+ Coverage     65.03%   65.07%   +0.03%     
- Complexity     3731     3735       +4     
============================================
  Files           297      297              
  Lines         21001    21007       +6     
  Branches       3440     3442       +2     
============================================
+ Hits          13659    13671      +12     
+ Misses         5637     5630       -7     
- Partials       1705     1706       +1     
Files Coverage Δ
...ic/auth/http/jwt/AbstractHTTPJwtAuthenticator.java 57.14% <33.33%> (-0.82%) ⬇️
...mazon/dlic/auth/http/jwt/HTTPJwtAuthenticator.java 74.25% <33.33%> (-1.26%) ⬇️

... and 4 files with indirect coverage changes

@cwperks cwperks merged commit dc0f0c5 into 2.x Dec 22, 2023
86 of 87 checks passed
@cwperks cwperks deleted the backport/backport-3887-to-2.x branch December 22, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant