Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/backport 3602 to 2.x #3862

Conversation

MaciejMierzwa
Copy link
Contributor

@MaciejMierzwa MaciejMierzwa commented Dec 18, 2023

Description

Integration test PR. I followed directions from #3602 (comment) not sure if it should look like that though.

Issues Resolved

This is backport
#3426
#3602

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@MaciejMierzwa MaciejMierzwa changed the base branch from main to 2.x December 18, 2023 13:17
@MaciejMierzwa MaciejMierzwa force-pushed the backport/backport-3602-to-2.x branch from 4962695 to 3679d43 Compare December 18, 2023 13:20
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea9546e) 65.00% compared to head (cbeadc1) 65.06%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #3862      +/-   ##
============================================
+ Coverage     65.00%   65.06%   +0.05%     
- Complexity     3732     3734       +2     
============================================
  Files           297      297              
  Lines         21000    21000              
  Branches       3439     3439              
============================================
+ Hits          13652    13663      +11     
+ Misses         5644     5634      -10     
+ Partials       1704     1703       -1     

see 3 files with indirect coverage changes

Search operation test flakiness fix
- opensearch-project#3426
- opensearch-project#2141
- opensearch-project#2169

Similar to this task:
opensearch-project#1917
From what I've noticed some logs are duplicated on faster machines.
During test creation audit logging results were added based on actual
results produced by tests. Now if there are slower moments where logging
produces non-duplicated logs, those were marked as failed.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

---------

Signed-off-by: Maciej Mierzwa <[email protected]>
Signed-off-by: MaciejMierzwa <[email protected]>
(cherry picked from commit 9da4a78)
Signed-off-by: Maciej Mierzwa <[email protected]>
@MaciejMierzwa MaciejMierzwa force-pushed the backport/backport-3602-to-2.x branch from 3679d43 to e0eefae Compare December 18, 2023 13:38
Copy link
Contributor

@stephen-crawford stephen-crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and compared this to main. This makes the files identical so assuming the CI passes this is appropriate. Thanks.

@stephen-crawford stephen-crawford merged commit 45917e9 into opensearch-project:2.x Dec 19, 2023
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants