Fix issue when scroll is created with LDAP user #3805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
cliu123,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3805 +/- ##
==========================================
+ Coverage 65.26% 65.32% +0.06%
==========================================
Files 297 298 +1
Lines 21132 21159 +27
Branches 3452 3455 +3
==========================================
+ Hits 13791 13822 +31
+ Misses 5644 5638 -6
- Partials 1697 1699 +2
|
willyborankin
previously approved these changes
Dec 7, 2023
Signed-off-by: Craig Perkins <[email protected]>
willyborankin
approved these changes
Dec 7, 2023
peternied
approved these changes
Dec 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 1846fd1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
cwperks
added a commit
that referenced
this pull request
Dec 13, 2023
Backport 1846fd1 from #3805. --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Craig Perkins <[email protected]>
3 tasks
prabhask5
pushed a commit
to prabhask5/opensearch-security
that referenced
this pull request
Jan 11, 2024
) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Prabhas Kurapati <[email protected]>
dlin2028
pushed a commit
to dlin2028/security
that referenced
this pull request
May 1, 2024
) Signed-off-by: Craig Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue when a scroll context is created by an LDAP User. There is a subclass in the system for LDAP Users that in some circumstances can lead to issues with the scroll query. The issue is always reproducible when using rest impersonation to impersonate the LDAP User when authenticating as an internal user.
See steps to reproduce the issue here: #3582 (comment)
This PR includes a test that will fail if the fix within User.java is reverted.
Bug fix
Issues Resolved
#3582
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.