[Enhancement-3191] transport_enabled setting on an auth domain and authorizer may be unnecessary after transport client removal

[prabhask5]

Description

Remove the transport_enabled setting in config.yml and its related code in DynamicConfigModel.

• Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
  Enhancement

• Why these changes are required?
  transport_enabled setting on an auth domain and authorizer may be unnecessary after transport client removal  #3191 states that since the transport client has been removed, there is no need for the transport_enabled config and its related code to exist in the codebase, so this ticket removes that unnecessary code.

• What is the old behavior before changes and new behavior after changes?
  Nothing.

Issues Resolved

#3191

Is this a backport? If so, please add backport PR # and/or commits #
No

Testing

No tests were made, all tests should run since the behavior should not change.

Check List

• New functionality includes testing
• New functionality has been documented
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

Merging #3754 (514ed8b) into main (5114bb7) will increase coverage by 0.18%.
The diff coverage is 50.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3754      +/-   ##
==========================================
+ Coverage   65.24%   65.43%   +0.18%     
==========================================
  Files         297      297              
  Lines       21129    21111      -18     
  Branches     3451     3446       -5     
==========================================
+ Hits        13786    13813      +27     
+ Misses       5643     5596      -47     
- Partials     1700     1702       +2     

Files	Coverage Δ
...ch/security/securityconf/DynamicConfigModelV7.java	77.71% <100.00%> (-0.01%)	⬇️
...ch/security/securityconf/DynamicConfigModelV6.java	0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

[cwperks]

@prabhask5 This change looks good to me, but is it backwards compatible. If someone uses the same config that includes transport_enabled as a setting will it read the config and ignore the value or will it fail to startup since there is an unknown config value? Can we add any logging in on startup to log that a removed setting is still being referenced in a config file and that it can be safely removed?

[stephen-crawford]

Closing this for inaction. Please open a new PR if you choose to pursue this change further.