[Backport 2.x] For read-only tenants filter with allow list #3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tenants were considered readonly an deny list was used, this could be prone to error, switch to an allow list instead. Added tests to confirm prevent and new state. Signed-off-by: Peter Nied <[email protected]> (cherry picked from commit 0914f8c)
DarshitChanpura
requested review from
cliu123,
cwperks,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #3528 +/- ##
============================================
+ Coverage 64.81% 64.85% +0.03%
- Complexity 3610 3612 +2
============================================
Files 273 273
Lines 20025 20026 +1
Branches 3346 3346
============================================
+ Hits 12980 12987 +7
+ Misses 5399 5395 -4
+ Partials 1646 1644 -2
|
stephen-crawford
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tenants were considered readonly an deny list was used, this could be prone to error, switch to an allow list instead. Added tests to confirm prevent and new state.
(cherry picked from commit 0914f8c)
Check List
- [ ] New functionality includes testing- [ ] New functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.