Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.11] Add missing license header (#3467) #3480

Conversation

DarshitChanpura
Copy link
Member

@DarshitChanpura DarshitChanpura commented Oct 6, 2023

Backports #3467 via fb82bbb

Manual backport is required to address white space conflicts in relevant files

Check List

- [ ] New functionality includes testing
- [ ] New functionality has been documented

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #3480 (4bafead) into 2.11 (ef1d27c) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               2.11    #3480   +/-   ##
=========================================
  Coverage     64.69%   64.70%           
  Complexity     3566     3566           
=========================================
  Files           267      267           
  Lines         19893    19893           
  Branches       3329     3329           
=========================================
+ Hits          12870    12871    +1     
+ Misses         5383     5379    -4     
- Partials       1640     1643    +3     
Files Coverage Δ
...curity/dlic/rest/validation/EndpointValidator.java 94.20% <ø> (ø)

... and 3 files with indirect coverage changes

Copy link
Collaborator

@RyanL1997 RyanL1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this until the release of 2.11 is done

Added missing license header for some files.

- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Andrey Pleskach <[email protected]>
(cherry picked from commit fb82bbb)
@DarshitChanpura DarshitChanpura force-pushed the backport/backport-3467-to-2.11 branch from e85c5cc to 4bafead Compare October 6, 2023 19:24
@DarshitChanpura DarshitChanpura dismissed RyanL1997’s stale review October 13, 2023 14:14

2.11 final RC is complete.

@DarshitChanpura DarshitChanpura merged commit fed822b into opensearch-project:2.11 Oct 13, 2023
55 of 56 checks passed
cwperks added a commit to cwperks/security that referenced this pull request Nov 6, 2023
RyanL1997 pushed a commit that referenced this pull request Nov 7, 2023
…3661)

### Description

Reverts 2 PRs added after the 2.11.0 release that should not be in the
2.11.1 release:

- #3486
- #3480

### Issues Resolved

#3650

### Check List
- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants