-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.11] Add missing license header (#3467) #3480
Merged
DarshitChanpura
merged 1 commit into
opensearch-project:2.11
from
DarshitChanpura:backport/backport-3467-to-2.11
Oct 13, 2023
Merged
[Backport 2.11] Add missing license header (#3467) #3480
DarshitChanpura
merged 1 commit into
opensearch-project:2.11
from
DarshitChanpura:backport/backport-3467-to-2.11
Oct 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarshitChanpura
requested review from
cliu123,
cwperks,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
October 6, 2023 16:59
Codecov Report
@@ Coverage Diff @@
## 2.11 #3480 +/- ##
=========================================
Coverage 64.69% 64.70%
Complexity 3566 3566
=========================================
Files 267 267
Lines 19893 19893
Branches 3329 3329
=========================================
+ Hits 12870 12871 +1
+ Misses 5383 5379 -4
- Partials 1640 1643 +3
|
reta
approved these changes
Oct 6, 2023
3 tasks
RyanL1997
previously requested changes
Oct 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking this until the release of 2.11 is done
Added missing license header for some files. - [ ] New functionality includes testing - [ ] New functionality has been documented - [ ] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). Signed-off-by: Andrey Pleskach <[email protected]> (cherry picked from commit fb82bbb)
DarshitChanpura
force-pushed
the
backport/backport-3467-to-2.11
branch
from
October 6, 2023 19:24
e85c5cc
to
4bafead
Compare
DarshitChanpura
dismissed
RyanL1997’s stale review
October 13, 2023 14:14
2.11 final RC is complete.
DarshitChanpura
merged commit Oct 13, 2023
fed822b
into
opensearch-project:2.11
55 of 56 checks passed
70 tasks
cwperks
added a commit
to cwperks/security
that referenced
this pull request
Nov 6, 2023
…t#3467) (opensearch-project#3480)" This reverts commit fed822b.
3 tasks
RyanL1997
pushed a commit
that referenced
this pull request
Nov 7, 2023
…3661) ### Description Reverts 2 PRs added after the 2.11.0 release that should not be in the 2.11.1 release: - #3486 - #3480 ### Issues Resolved #3650 ### Check List - [ ] New functionality includes testing - [ ] New functionality has been documented - [ ] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #3467 via fb82bbb
Manual backport is required to address white space conflicts in relevant files
Check List
- [ ] New functionality includes testing- [ ] New functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.