[Backport 2.x] Support security config updates on the REST API using permission (#3264) #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willyborankin
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford and
reta
as code owners
willyborankin
force-pushed
the
backport-3264-to-2.x
branch
from
3379db8 to
9480a22
Compare
|
That BWC failure looks like it was a network hiccup, but could you take a look just to confirm? It was on linux which classically hasn't had those kinds of problems. |
…nsearch-project#3264) Instead of setting `SECURITY_UNSUPPORTED_RESTAPI_ALLOW_SECURITYCONFIG_MODIFICATION` settings to update security configuration using `PATCH` or `PUT` a new permission was added: `restapi:admin/config/update`. So far I decided to keep this flag as it is due to a backward compatibility and log a deprecation message that these settings will be removed in the future. Maybe it is better to remove it completely. Besides, added the missed test for `SecurityConfigApiAction` Signed-off-by: Andrey Pleskach <[email protected]> (cherry picked from commit e4a1b77) Signed-off-by: Andrey Pleskach <[email protected]>
willyborankin
force-pushed
the
backport-3264-to-2.x
branch
from
9480a22 to
ec3081a
Compare
I just re-ran it. All others tests passed. I think it was a regular hickup |
Codecov Report
@@ Coverage Diff @@
## 2.x #3459 +/- ##
============================================
+ Coverage 64.61% 64.66% +0.04%
- Complexity 3535 3539 +4
============================================
Files 261 261
Lines 19806 19808 +2
Branches 3323 3324 +1
============================================
+ Hits 12798 12808 +10
+ Misses 5370 5366 -4
+ Partials 1638 1634 -4
|
peternied
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e4a1b77 from #3264