-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport/backport-2802-to-2.x? #3429
backport/backport-2802-to-2.x? #3429
Conversation
Use custom serialization in security plugin. - Resolves opensearch-project#2780 Signed-off-by: Paras Jain <[email protected]> Signed-off-by: Peter Nied <[email protected]> Co-authored-by: Paras Jain <[email protected]> Co-authored-by: Peter Nied <[email protected]> Signed-off-by: Paras Jain <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.x #3429 +/- ##
============================================
+ Coverage 64.11% 64.56% +0.45%
- Complexity 3367 3508 +141
============================================
Files 256 260 +4
Lines 19515 19719 +204
Branches 3297 3308 +11
============================================
+ Hits 12512 12732 +220
+ Misses 5360 5356 -4
+ Partials 1643 1631 -12
|
@parasjain1 Is this targeting 2.11 release? |
@DarshitChanpura yes this is targeting 2.11 release. |
FYI BWC tests are failing due to compilation failures. Seems like the recent fixes were not backported to 2.x.
|
@parasjain1 The compilation failures are due to a difference in the version of the Apache HttpClient/HttpComponent libraries used in main vs 2.x. main uses HttpClientV5 while 2.x uses HttpClientV4. This PR will need to adjust to the difference between the main and 2.x branch of the security plugin. |
Closing as #3444 was merged. |
Use custom serialization in security plugin.
Description
Refer #2802
Issues Resolved
Is this a backport? If so, please add backport PR # and/or commits #
Yes
#2802
Testing
Refer
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.