Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Refactor] Change HTTP routes for Audit and Config PUT methods #3407

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 22f00fa from #3359.

Change routs for audit and security configuration PUT methods.
The previous configuration used the `{name}` parameter which is
confusing since `config` the only allowed value for this parameter. This
PR changes routes' configuration and removes useless validation for
them.

Signed-off-by: Andrey Pleskach <[email protected]>
(cherry picked from commit 22f00fa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #3407 (3ceff30) into 2.x (8b03022) will decrease coverage by 0.01%.
Report is 2 commits behind head on 2.x.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #3407      +/-   ##
============================================
- Coverage     64.10%   64.10%   -0.01%     
+ Complexity     3367     3366       -1     
============================================
  Files           256      256              
  Lines         19515    19510       -5     
  Branches       3297     3295       -2     
============================================
- Hits          12511    12507       -4     
+ Misses         5362     5360       -2     
- Partials       1642     1643       +1     
Files Coverage Δ
...arch/security/dlic/rest/api/AbstractApiAction.java 88.61% <100.00%> (+0.04%) ⬆️
...nsearch/security/dlic/rest/api/AuditApiAction.java 90.76% <100.00%> (-0.41%) ⬇️
...ecurity/dlic/rest/api/SecurityConfigApiAction.java 93.10% <100.00%> (-0.65%) ⬇️

... and 1 file with indirect coverage changes

@DarshitChanpura DarshitChanpura merged commit 9932f10 into 2.x Oct 2, 2023
98 of 101 checks passed
@DarshitChanpura DarshitChanpura deleted the backport/backport-3359-to-2.x branch October 2, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants