-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use version of org.apache.commons:commons-lang3 defined in core #3306
Use version of org.apache.commons:commons-lang3 defined in core #3306
Conversation
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
FYI we are getting this dependency transitively through rest-highlevel-client now. It's coming through the new
|
Seeing this error on plugin install:
Its odd because this grant is already defined in |
Codecov Report
@@ Coverage Diff @@
## main #3306 +/- ##
============================================
- Coverage 63.27% 63.23% -0.04%
+ Complexity 3450 3448 -2
============================================
Files 263 263
Lines 20040 20040
Branches 3344 3344
============================================
- Hits 12680 12673 -7
- Misses 5732 5740 +8
+ Partials 1628 1627 -1 |
@cwperks looks like implementation "org.bouncycastle:bcprov-jdk15to18:${versions.bouncycastle}" is in the SDK now. |
@reta looks like cryto-sdk brought BC as deps without permissions as result Sec plugin does not work and I think other plugins as well. OS now tries to check permissions via SDK but not via plugin :-) |
Associated change [1] & backport [2] |
I am going to push this change in, we need to figure out what is wrong with the SecurityManager, but let's handle that separately from this version alignment that needs to happen across main & 2.x |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3306-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fd3a143be713a31c278386a21bd2236542101b7d
# Push it to GitHub
git push --set-upstream origin backport/backport-3306-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x Then, create a pull request where the |
Opened backport: #3307 |
…d in core (opensearch-project#3306) Backport of fd3a143 from opensearch-project#3306 Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Peter Nied <[email protected]>
@peternied I suspect we need use it as static instance and do not register as a default security provider. Given the fact that we do not have good tests for permissions. It will take sometime to pass BC instance through all code base we have. |
Yeah, I think we have a problem now ....
I don't really understand why it is needed there, but things are messed up now |
Creating manually backport [1] |
I've created an issue to track this problem [1] impacting both main and the 2.10 line |
…d in core (#3307) Backport of #3306 to 2.x Signed-off-by: Craig Perkins <[email protected]>
…search-project#3306) Use version of org.apache.commons:commons-lang3 defined in core Signed-off-by: Craig Perkins <[email protected]>
Description
Use version of org.apache.commons:commons-lang3 defined in core
https://github.com/opensearch-project/OpenSearch/blob/main/buildSrc/version.properties#L42
Fixes issue seen on spotless upgrade PR against 2.x: #3298
Maintenance
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.