[Backport 2.x] Generate new demo certs with IPv6 loopback added to SAN in node certificate (#3268) #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ficate (opensearch-project#3268) Solves bug where backwards compatibility tests would fail for IPv6 loopback address (`::1`) with: `No subject alternative names matching IP address ::1 found` Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit a4f8f03)
DarshitChanpura
requested review from
cliu123,
cwperks,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #3277 +/- ##
=========================================
Coverage 62.33% 62.34%
- Complexity 3293 3294 +1
=========================================
Files 252 252
Lines 19457 19462 +5
Branches 3308 3308
=========================================
+ Hits 12129 12134 +5
Misses 5708 5708
Partials 1620 1620
|
peternied
approved these changes
Aug 31, 2023
cwperks
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #3268 by cherry-picking a4f8f03
Manual backport was required to address conflicts in DEVELOPER_GUIDE.md