Skip role immutable check for Roles Mappings APIs #3272
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@willyborankin I'm opening up a Draft PR that fixes this issue locally, but wanted to get your input too. There are security-dashboards-tests failing because they cannot clean up test data by using the patch API to modify the
all_access
roles mapping and the request fails with this error:I believe the fix is to skip the
validateRoles
check on the RolesMapping API. Essentially roles can be static or hidden, but roles mappings cannot be. Any roles mapping is editable.Test failures seen on this PR: opensearch-project/security-dashboards-plugin#1568
Example integ test run with test failures: https://github.com/opensearch-project/security-dashboards-plugin/actions/runs/6031350472/job/16364885321?pr=1568
This failure is related to the recent change to refactor the REST APIs: #3123
Bug fix
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.