[Backport 2.x] Clean up sysouts and replace with logger statements where necessary (#3231) #3240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pensearch-project#3231) A lot of files (mostly tests) have sysout's which do nothing but degrade the performance. This PR removes all sysouts from tests, replace sysouts with logger in project files. Also removes all e.printStacktrace(); calls. - `tools/` package - no sysouts were removed from here - HTTPSpnegoAuthenticator.java - a portion was not modified since it enabled debugging on console. Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 683c4f5)
DarshitChanpura
requested review from
cliu123,
cwperks,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #3240 +/- ##
============================================
+ Coverage 62.32% 62.35% +0.02%
+ Complexity 3293 3290 -3
============================================
Files 252 252
Lines 19467 19456 -11
Branches 3308 3308
============================================
- Hits 12133 12131 -2
+ Misses 5717 5704 -13
- Partials 1617 1621 +4
|
Signed-off-by: Darshit Chanpura <[email protected]>
peternied
previously approved these changes
Aug 25, 2023
peternied
previously approved these changes
Aug 25, 2023
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
force-pushed
the
backport/backport-3231-to-2.x
branch
from
3b31607 to
7f2eabb
Compare
peternied
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #3231.
Needed manual backport because of http5 imports and server
shutdown(2.x) vsawaitTermination(main) method calls in test.Check List
- [ ] New functionality includes testing- [ ] New functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.