-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build Break] Update CircuitBreakerService and LifecycleComponent after core refactor in #9006 #3082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
cliu123,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
August 1, 2023 15:13
Codecov Report
@@ Coverage Diff @@
## main #3082 +/- ##
============================================
- Coverage 62.40% 62.37% -0.03%
+ Complexity 3350 3347 -3
============================================
Files 254 254
Lines 19741 19741
Branches 3334 3334
============================================
- Hits 12319 12314 -5
- Misses 5790 5792 +2
- Partials 1632 1635 +3
|
willyborankin
approved these changes
Aug 1, 2023
derek-ho
approved these changes
Aug 1, 2023
reta
approved these changes
Aug 1, 2023
Not sure what is going on with that node, was able to build (via assemble task) on windows, merging.
|
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
…or in #9006 (#3082) This PR reacts to changes introduced in core in this PR: opensearch-project/OpenSearch#9006 Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 5384272) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
cwperks
added a commit
to cwperks/security
that referenced
this pull request
Aug 2, 2023
…or in #9006 (opensearch-project#3082) This PR reacts to changes introduced in core in this PR: opensearch-project/OpenSearch#9006 Signed-off-by: Craig Perkins <[email protected]>
reta
pushed a commit
that referenced
this pull request
Aug 2, 2023
…ter core refactor in #9006 (#3089) Manual backport of #3082 and #3050 to 2.x --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Ryan Liang <[email protected]> Co-authored-by: Ryan Liang <[email protected]>
peternied
changed the title
Update CircuitBreakerService and LifecycleComponent after core refactor in #9006
[Build Break] Update CircuitBreakerService and LifecycleComponent after core refactor in #9006
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reacts to changes introduced in core in this PR: opensearch-project/OpenSearch#9006
Maintenance
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.