Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build Break] Update CircuitBreakerService and LifecycleComponent after core refactor in #9006 #3082

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Aug 1, 2023

Description

This PR reacts to changes introduced in core in this PR: opensearch-project/OpenSearch#9006

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #3082 (6441713) into main (eac670f) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3082      +/-   ##
============================================
- Coverage     62.40%   62.37%   -0.03%     
+ Complexity     3350     3347       -3     
============================================
  Files           254      254              
  Lines         19741    19741              
  Branches       3334     3334              
============================================
- Hits          12319    12314       -5     
- Misses         5790     5792       +2     
- Partials       1632     1635       +3     
Files Changed Coverage Δ
.../opensearch/security/OpenSearchSecurityPlugin.java 84.34% <ø> (ø)
...arch/security/ssl/OpenSearchSecuritySSLPlugin.java 83.56% <ø> (ø)
...urity/ssl/transport/SecuritySSLNettyTransport.java 62.00% <ø> (ø)

... and 3 files with indirect coverage changes

@cwperks cwperks added the backport 2.x backport to 2.x branch label Aug 1, 2023
@peternied
Copy link
Member

Not sure what is going on with that node, was able to build (via assemble task) on windows, merging.

C:\Users\petern\Documents\GitHub\security>gradlew assemble
Picked up JAVA_TOOL_OPTIONS: -Dlog4j2.formatMsgNoLookups=true
Starting a Gradle Daemon (subsequent builds will be faster)
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 8.2.1
  OS Info               : Windows 10 10.0 (amd64)
  JDK Version           : 17 (Oracle JDK)
  JAVA_HOME             : C:\Program Files\Java\jdk-17
  Random Testing Seed   : 6053480FD7C2B416
  In FIPS 140 mode      : false
=======================================

> Task :compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.2.1/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 1m 52s
11 actionable tasks: 11 executed
C:\Users\petern\Documents\GitHub\security>

@peternied peternied merged commit 5384272 into opensearch-project:main Aug 1, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 1, 2023
…or in #9006 (#3082)

This PR reacts to changes introduced in core in this PR:
opensearch-project/OpenSearch#9006

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 5384272)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
cwperks added a commit to cwperks/security that referenced this pull request Aug 2, 2023
…or in #9006 (opensearch-project#3082)

This PR reacts to changes introduced in core in this PR:
opensearch-project/OpenSearch#9006

Signed-off-by: Craig Perkins <[email protected]>
reta pushed a commit that referenced this pull request Aug 2, 2023
…ter core refactor in #9006 (#3089)

Manual backport of
#3082 and
#3050 to 2.x

---------

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Co-authored-by: Ryan Liang <[email protected]>
@peternied peternied changed the title Update CircuitBreakerService and LifecycleComponent after core refactor in #9006 [Build Break] Update CircuitBreakerService and LifecycleComponent after core refactor in #9006 Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants