Service Accounts password is randomly generated #3077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Crawford <[email protected]>
stephen-crawford
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
reta and
willyborankin
as code owners
Codecov Report
@@ Coverage Diff @@
## main #3077 +/- ##
============================================
- Coverage 62.44% 62.37% -0.07%
+ Complexity 3352 3350 -2
============================================
Files 254 254
Lines 19741 19747 +6
Branches 3334 3334
============================================
- Hits 12327 12317 -10
- Misses 5785 5797 +12
- Partials 1629 1633 +4
|
willyborankin
previously approved these changes
Aug 2, 2023
cwperks
previously approved these changes
Aug 2, 2023
peternied
previously approved these changes
Aug 3, 2023
stephen-crawford
dismissed stale reviews from cwperks, peternied, and willyborankin
via
a12f2fc
Signed-off-by: Stephen Crawford <[email protected]>
willyborankin
approved these changes
Aug 4, 2023
peternied
approved these changes
Aug 4, 2023
peternied
added
backport 2.x
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
Uses Passay to generate a random password for service accounts where each password is between 8 and 16 characters and has at least 1 of each: lower case letter, upper case letter, digit, special symbol. Signed-off-by: Stephen Crawford <[email protected]> (cherry picked from commit 1822e13) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peternied
added a commit
that referenced
this pull request
Aug 9, 2023
Backport 1822e13 from #3077. Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Peter Nied <[email protected]> Co-authored-by: Craig Perkins <[email protected]>
peternied
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses Passay to generate a random password for service accounts where each password is between 8 and 16 characters and has at least 1 of each: lower case letter, upper case letter, digit, special symbol.
Issues Resolved
#3076
Testing
Added password validation test to UserAPITest
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.