Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3] Update guava to address CVE-2023-2976 #3060

Merged
merged 6 commits into from
Jul 31, 2023
Merged

[1.3] Update guava to address CVE-2023-2976 #3060

merged 6 commits into from
Jul 31, 2023

Conversation

jaguilar-atl
Copy link

@jaguilar-atl jaguilar-atl commented Jul 27, 2023

Description

Update guava to address CVE-2023-2976.

Seems like this has been resolved for 2.x so this PR is for the 1.3 branch.

Issues Resolved

#2940

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

cwperks
cwperks previously approved these changes Jul 27, 2023
build.gradle Outdated
@@ -84,7 +84,7 @@ configurations.all {
force "org.apache.commons:commons-lang3:3.4"
force "org.springframework:spring-core:5.3.28"
force "org.springframework:spring-expression:5.3.28"
force "com.google.guava:guava:30.0-jre"
force "com.google.guava:guava:32.0.1-jre"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We bumped to 32.1.1-jre everywhere, shouldn't we use the latest here as well? thanks!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @reta! I just went the the minimum required but happy to bump it up to the latest version if that's preferrable as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 🎉

Signed-off-by: Josh Aguilar <[email protected]>
cwperks
cwperks previously approved these changes Jul 27, 2023
reta
reta previously approved these changes Jul 27, 2023
@cwperks cwperks changed the title Update guava to address CVE-2023-2976 [1.3] Update guava to address CVE-2023-2976 Jul 31, 2023
Signed-off-by: Stephen Crawford <[email protected]>
@stephen-crawford stephen-crawford dismissed stale reviews from reta and cwperks via 28fe6aa July 31, 2023 18:43
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@cwperks cwperks merged commit eb9f698 into opensearch-project:1.3 Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants