Add geospatial ip2geo to the demo configuration system indices and roles #3051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heemin32
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
Codecov Report
@@ Coverage Diff @@
## main #3051 +/- ##
============================================
- Coverage 62.43% 62.37% -0.06%
+ Complexity 3352 3348 -4
============================================
Files 254 254
Lines 19741 19741
Branches 3334 3334
============================================
- Hits 12325 12314 -11
- Misses 5787 5793 +6
- Partials 1629 1634 +5 |
cwperks
reviewed
Jul 27, 2023
tools/install_demo_configuration.bat
Outdated
| @@ -315,7 +315,7 @@ echo plugins.security.enable_snapshot_restore_privilege: true >> "%OPENSEARCH_CO | |||
| echo plugins.security.check_snapshot_restore_write_privileges: true >> "%OPENSEARCH_CONF_FILE%" | |||
| echo plugins.security.restapi.roles_enabled: ["all_access", "security_rest_api_access"] >> "%OPENSEARCH_CONF_FILE%" | |||
| echo plugins.security.system_indices.enabled: true >> "%OPENSEARCH_CONF_FILE%" | |||
| echo plugins.security.system_indices.indices: [".plugins-ml-config", ".plugins-ml-connector", ".plugins-ml-model-group", ".plugins-ml-model", ".plugins-ml-task", ".opendistro-alerting-config", ".opendistro-alerting-alert*", ".opendistro-anomaly-results*", ".opendistro-anomaly-detector*", ".opendistro-anomaly-checkpoints", ".opendistro-anomaly-detection-state", ".opendistro-reports-*", ".opensearch-notifications-*", ".opensearch-notebooks", ".opensearch-observability", ".ql-datasources", ".opendistro-asynchronous-search-response*", ".replication-metadata-store", ".opensearch-knn-models"] >> "%OPENSEARCH_CONF_FILE%" | |||
| echo plugins.security.system_indices.indices: [".plugins-ml-config", ".plugins-ml-connector", ".plugins-ml-model-group", ".plugins-ml-model", ".plugins-ml-task", ".opendistro-alerting-config", ".opendistro-alerting-alert*", ".opendistro-anomaly-results*", ".opendistro-anomaly-detector*", ".opendistro-anomaly-checkpoints", ".opendistro-anomaly-detection-state", ".opendistro-reports-*", ".opensearch-notifications-*", ".opensearch-notebooks", ".opensearch-observability", ".ql-datasources", ".opendistro-asynchronous-search-response*", ".replication-metadata-store", ".opensearch-knn-models", ".geospatial.ip2geo.data.*"] >> "%OPENSEARCH_CONF_FILE%" | |||
There was a problem hiding this comment.
Curious, is there any reason why you are using . as a delimiter in the system index name? In all other cases in this list, plugins use hyphens. While its possible to use dot separation, would hyphen be better for consistency?
There was a problem hiding this comment.
Make sense. Let me update it.
|
@heemin32 Is this change targeting 2.10? |
Yes |
cwperks
approved these changes
Jul 27, 2023
|
@heemin32 Can you rebase this PR with main? There were some recent build fixing PRs merged. |
Signed-off-by: Heemin Kim <[email protected]>
Thanks! Rebased. |
|
Can another maintainer please review this PR? |
peternied
approved these changes
Aug 1, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
### Description Adds 2 ip2geo related roles to the plugin: read only and fully access. Adds ip2geo system index to demo scripts as well. Signed-off-by: Heemin Kim <[email protected]> (cherry picked from commit 634e3af)
cwperks
added a commit
that referenced
this pull request
Aug 1, 2023
…y plugin (#3081) Backport 634e3af from #3051 Co-authored-by: Heemin Kim <[email protected]> Co-authored-by: Craig Perkins <[email protected]>
peternied
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds 2 ip2geo related roles to the plugin: read only and fully access.
Adds ip2geo system index to demo scripts as well.
Issues Resolved
N/A
Testing
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.