Fix log4j and guava deps for bwc-tests #3004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willyborankin
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford and
reta
as code owners
3 tasks
reta
previously approved these changes
Jul 13, 2023
Signed-off-by: Andrey Pleskach <[email protected]>
willyborankin
changed the title
reta
reviewed
Jul 13, 2023
| @@ -67,9 +67,9 @@ repositories { | |||
| } | |||
|
|
|||
| dependencies { | |||
| testImplementation 'com.google.guava:guava:30.0-jre' | |||
| testImplementation 'com.google.guava:guava:32.1.1-jre' | |||
There was a problem hiding this comment.
Suggested change
| testImplementation 'com.google.guava:guava:32.1.1-jre' | |
| testImplementation "com.google.guava:guava:${versions.guava}" |
?
|
@willyborankin I think it is covered by #3003 |
|
@willyborankin Both of these changes are being incorporated on this build fixing PR: #3003 There is still the ongoing issue with the bwc check somehow using a stale version of core instead of the latest from HEAD on main |
|
got it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Fix log4j and guava deps for bwc-tests used hardcoded version
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.