Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Adds a check to skip serialization-deserialization if request is for same node (#2765) #2973

Conversation

DarshitChanpura
Copy link
Member

@DarshitChanpura DarshitChanpura commented Jul 10, 2023

Description

Backports #2765

Check List

  • New functionality includes testing
    - [] New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…same node (opensearch-project#2765)

Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
(cherry picked from commit 8d636c4)
@DarshitChanpura
Copy link
Member Author

White source check will be unblocked once, #2974 is merged.

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #2973 (8abd987) into 2.x (1ec67d6) will decrease coverage by 0.01%.
The diff coverage is 72.34%.

@@             Coverage Diff              @@
##                2.x    #2973      +/-   ##
============================================
- Coverage     62.20%   62.20%   -0.01%     
- Complexity     3302     3307       +5     
============================================
  Files           264      264              
  Lines         19460    19468       +8     
  Branches       3319     3326       +7     
============================================
+ Hits          12106    12110       +4     
- Misses         5729     5730       +1     
- Partials       1625     1628       +3     
Impacted Files Coverage Δ
...rch/security/transport/SecurityRequestHandler.java 54.72% <47.61%> (-2.24%) ⬇️
...search/security/transport/SecurityInterceptor.java 72.90% <90.90%> (-0.15%) ⬇️
.../opensearch/security/OpenSearchSecurityPlugin.java 84.31% <100.00%> (+0.09%) ⬆️

... and 6 files with indirect coverage changes

@DarshitChanpura DarshitChanpura merged commit ddbe517 into opensearch-project:2.x Jul 11, 2023
cwperks added a commit to cwperks/security that referenced this pull request Jul 21, 2023
DarshitChanpura added a commit to DarshitChanpura/security that referenced this pull request Jul 24, 2023
DarshitChanpura added a commit to DarshitChanpura/security that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.9.0 v2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants