Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot: bump org.glassfish.jaxb:jaxb-runtime from 2.3.4 to 4.0.3 #2970

Merged
merged 1 commit into from
Jul 10, 2023
Merged

dependabot: bump org.glassfish.jaxb:jaxb-runtime from 2.3.4 to 4.0.3 #2970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ dependencies {
runtimeOnly 'io.jsonwebtoken:jjwt-jackson:0.10.8'
runtimeOnly 'com.google.guava:failureaccess:1.0.1'
runtimeOnly 'org.apache.commons:commons-text:1.10.0'
runtimeOnly 'org.glassfish.jaxb:jaxb-runtime:2.3.4'
runtimeOnly 'org.glassfish.jaxb:jaxb-runtime:4.0.3'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scrawfor99 sorry, I am late, but 2.x is javax.* based whereas 3.x+ is jakarta.* based, I think this is not compatible change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reta Does this need to be reverted? I can open a PR to revert the change.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwperks I think so, we could bump to 2.3.8 though, thank you

https://mvnrepository.com/artifact/org.glassfish.jaxb/jaxb-runtime/2.3.8

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened up a PR to revert the change and bump all jaxb dependencies: #2977

runtimeOnly 'com.google.j2objc:j2objc-annotations:2.8'
runtimeOnly 'com.google.code.findbugs:jsr305:3.0.2'
runtimeOnly 'com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava'
Expand Down