Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Use version of httpclient 4 from core's buildSrc/version.properties #2952

Closed
wants to merge 1 commit into from

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jul 7, 2023

Description

This PR solves for the issue in backwards compatibility tests seen in PRs like: #2949

> Task :compileJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> Could not resolve all dependencies for configuration ':compileClasspath'.
   > Conflict(s) found for the following module(s):
       - org.apache.httpcomponents:httpclient between versions 4.5.14 and 4.5.13
     Run with:
         --scan or
         :dependencyInsight --configuration compileClasspath --dependency org.apache.httpcomponents:httpclient
     to get more insight on how to solve the conflict.
  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks
Copy link
Member Author

cwperks commented Jul 7, 2023

#2781 needs to be backported to 2.x. I just added a backport 2.x label.

@cwperks
Copy link
Member Author

cwperks commented Jul 7, 2023

Manual backport for the core refactor change created: #2953

Should I bundle this change into that PR?

@cwperks
Copy link
Member Author

cwperks commented Jul 7, 2023

Closing this PR and incorporating the changes its introducing into this PR: #2953

@cwperks cwperks closed this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant