Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Manual Backport of Dynamic tenancy configurations #2696

Merged

Conversation

RyanL1997
Copy link
Collaborator

Description

Manual Backport of Dynamic tenancy configurations to 2.x

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
    New feature

Issues Resolved

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…nsearch-project#2693)

* Manual Backport of Dynamic tenancy configurations
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Abhi Kalra <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

Merging #2696 (95b70e8) into 2.x (02633c5) will increase coverage by 0.10%.
The diff coverage is 76.13%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #2696      +/-   ##
============================================
+ Coverage     61.19%   61.29%   +0.10%     
- Complexity     3259     3307      +48     
============================================
  Files           259      268       +9     
  Lines         18183    18336     +153     
  Branches       3234     3242       +8     
============================================
+ Hits          11127    11239     +112     
- Misses         5488     5523      +35     
- Partials       1568     1574       +6     
Impacted Files Coverage Δ
...earch/security/dlic/rest/api/MigrateApiAction.java 4.16% <0.00%> (ø)
...arch/security/securityconf/DynamicConfigModel.java 100.00% <ø> (ø)
...ch/security/securityconf/DynamicConfigModelV6.java 0.00% <0.00%> (ø)
...g/opensearch/security/support/ConfigConstants.java 94.44% <ø> (ø)
.../action/tenancy/TenancyConfigRetrieveResponse.java 54.16% <54.16%> (ø)
...ensearch/security/action/tenancy/EmptyRequest.java 60.00% <60.00%> (ø)
...ity/action/tenancy/TenancyConfigUpdateRequest.java 64.00% <64.00%> (ø)
...earch/security/privileges/PrivilegesEvaluator.java 72.95% <66.66%> (+0.57%) ⬆️
...urity/action/tenancy/TenancyConfigRestHandler.java 77.77% <77.77%> (ø)
...search/security/securityconf/impl/v7/ConfigV7.java 74.55% <80.00%> (+0.61%) ⬆️
... and 16 more

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@stephen-crawford stephen-crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ryan!

@RyanL1997 RyanL1997 merged commit f79faec into opensearch-project:2.x Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants