-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NPE and add additional graceful error handling #2687
Fix NPE and add additional graceful error handling #2687
Conversation
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Craig.
src/main/java/org/opensearch/security/OpenSearchSecurityPlugin.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <[email protected]>
8f4905a
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2687 +/- ##
============================================
+ Coverage 61.38% 61.44% +0.06%
- Complexity 3383 3385 +2
============================================
Files 269 270 +1
Lines 18668 18694 +26
Branches 3279 3279
============================================
+ Hits 11459 11487 +28
+ Misses 5613 5611 -2
Partials 1596 1596
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-2687-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ed4df62fcb5a3c54869db70dcaf0283472751591
# Push it to GitHub
git push --set-upstream origin backport/backport-2687-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-2687-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ed4df62fcb5a3c54869db70dcaf0283472751591
# Push it to GitHub
git push --set-upstream origin backport/backport-2687-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3 Then, create a pull request where the |
* Fix NPE and add additional graceful error handling Signed-off-by: Craig Perkins <[email protected]> * Add new lines at end of file Signed-off-by: Craig Perkins <[email protected]> * Run spotlessApply Signed-off-by: Craig Perkins <[email protected]> * Remove unused import Signed-off-by: Craig Perkins <[email protected]> * volatile to final Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit ed4df62)
* Fix NPE and add additional graceful error handling Signed-off-by: Craig Perkins <[email protected]> * Add new lines at end of file Signed-off-by: Craig Perkins <[email protected]> * Run spotlessApply Signed-off-by: Craig Perkins <[email protected]> * Remove unused import Signed-off-by: Craig Perkins <[email protected]> * volatile to final Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit ed4df62)
* Fix NPE and add additional graceful error handling Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit ed4df62)
* Fix NPE and add additional graceful error handling Signed-off-by: Craig Perkins <[email protected]>
…t#2687) * Fix NPE and add additional graceful error handling Signed-off-by: Craig Perkins <[email protected]> * Add new lines at end of file Signed-off-by: Craig Perkins <[email protected]> * Run spotlessApply Signed-off-by: Craig Perkins <[email protected]> * Remove unused import Signed-off-by: Craig Perkins <[email protected]> * volatile to final Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
…t#2687) * Fix NPE and add additional graceful error handling Signed-off-by: Craig Perkins <[email protected]> * Add new lines at end of file Signed-off-by: Craig Perkins <[email protected]> * Run spotlessApply Signed-off-by: Craig Perkins <[email protected]> * Remove unused import Signed-off-by: Craig Perkins <[email protected]> * volatile to final Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Maciej Mierzwa <[email protected]>
…t#2687) * Fix NPE and add additional graceful error handling Signed-off-by: Craig Perkins <[email protected]> * Add new lines at end of file Signed-off-by: Craig Perkins <[email protected]> * Run spotlessApply Signed-off-by: Craig Perkins <[email protected]> * Remove unused import Signed-off-by: Craig Perkins <[email protected]> * volatile to final Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Maciej Mierzwa <[email protected]>
…t#2687) * Fix NPE and add additional graceful error handling Signed-off-by: Craig Perkins <[email protected]> * Add new lines at end of file Signed-off-by: Craig Perkins <[email protected]> * Run spotlessApply Signed-off-by: Craig Perkins <[email protected]> * Remove unused import Signed-off-by: Craig Perkins <[email protected]> * volatile to final Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Maciej Mierzwa <[email protected]>
…t#2687) * Fix NPE and add additional graceful error handling Signed-off-by: Craig Perkins <[email protected]> * Add new lines at end of file Signed-off-by: Craig Perkins <[email protected]> * Run spotlessApply Signed-off-by: Craig Perkins <[email protected]> * Remove unused import Signed-off-by: Craig Perkins <[email protected]> * volatile to final Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Maciej Mierzwa <[email protected]>
…t#2687) * Fix NPE and add additional graceful error handling Signed-off-by: Craig Perkins <[email protected]> * Add new lines at end of file Signed-off-by: Craig Perkins <[email protected]> * Run spotlessApply Signed-off-by: Craig Perkins <[email protected]> * Remove unused import Signed-off-by: Craig Perkins <[email protected]> * volatile to final Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Sam <[email protected]>
Description
This PR adds graceful error handling in a cache miss scenario where the error is swallowed. Additional tests have been added to verify the new functionality.
Testing
See associated unit tests added
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.