-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chmod 0600 to install_demo_configuration bash script #2550
Merged
stephen-crawford
merged 1 commit into
opensearch-project:main
from
cwperks:demo-cert-permissions
Mar 14, 2023
Merged
Add chmod 0600 to install_demo_configuration bash script #2550
stephen-crawford
merged 1 commit into
opensearch-project:main
from
cwperks:demo-cert-permissions
Mar 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
cliu123,
DarshitChanpura,
davidlago,
peternied,
RyanL1997 and
stephen-crawford
as code owners
March 13, 2023 22:00
peternied
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to see on another pull request that the error appeared in the plugin-install workflow and it did not appear in teh
stephen-crawford
approved these changes
Mar 14, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2023
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit ca4d752)
cwperks
added a commit
that referenced
this pull request
Mar 15, 2023
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit ca4d752) Co-authored-by: Craig Perkins <[email protected]>
Rishikesh1159
added a commit
to Rishikesh1159/security
that referenced
this pull request
Mar 15, 2023
) (opensearch-project#2555)" This reverts commit 623e6e5.
cwperks
added
backport 1.x
backport to 1.x branch
backport 1.3
backport to 1.3 branch
labels
Mar 17, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit ca4d752)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit ca4d752)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit ca4d752)
cwperks
added a commit
that referenced
this pull request
Mar 17, 2023
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit ca4d752) Co-authored-by: Craig Perkins <[email protected]>
peternied
pushed a commit
that referenced
this pull request
Mar 19, 2023
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit ca4d752) Co-authored-by: Craig Perkins <[email protected]>
peternied
pushed a commit
that referenced
this pull request
Mar 21, 2023
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit ca4d752) Co-authored-by: Craig Perkins <[email protected]>
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Apr 20, 2023
Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Maciej Mierzwa <[email protected]>
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Apr 27, 2023
Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Maciej Mierzwa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 1.x
backport to 1.x branch
backport 1.3
backport to 1.3 branch
backport 2.x
backport to 2.x branch
backport 2.6
backport to 2.6 branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds commands to change the permissions of the newly created demo certificates in the install_demo_configuration.sh script.
This PR only changes the certificate permissions, the other issue with the
config/
folder permissions should be addressed in opensearch-build:Bug fix
Issues Resolved
Testing
Tested a local distribution before and after the change and verified that the
...has insecure file permissions (should be 0600)
errors were not logged.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.