Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chmod 0600 to install_demo_configuration bash script #2550

Merged

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Mar 13, 2023

Description

Adds commands to change the permissions of the newly created demo certificates in the install_demo_configuration.sh script.

This PR only changes the certificate permissions, the other issue with the config/ folder permissions should be addressed in opensearch-build:

... Directory /home/ec2-user/opensearch-1.1.0/config has insecure file permissions (should be 0700)
  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Bug fix

Issues Resolved

Testing

Tested a local distribution before and after the change and verified that the ...has insecure file permissions (should be 0600) errors were not logged.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to see on another pull request that the error appeared in the plugin-install workflow and it did not appear in teh

@stephen-crawford stephen-crawford merged commit ca4d752 into opensearch-project:main Mar 14, 2023
@cwperks cwperks added the backport 2.x backport to 2.x branch label Mar 15, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 15, 2023
Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit ca4d752)
cwperks added a commit that referenced this pull request Mar 15, 2023
Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit ca4d752)

Co-authored-by: Craig Perkins <[email protected]>
Rishikesh1159 added a commit to Rishikesh1159/security that referenced this pull request Mar 15, 2023
@cwperks cwperks added backport 1.x backport to 1.x branch backport 1.3 backport to 1.3 branch labels Mar 17, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 17, 2023
Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit ca4d752)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 17, 2023
Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit ca4d752)
@peterzhuamazon peterzhuamazon added the backport 2.6 backport to 2.6 branch label Mar 17, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 17, 2023
Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit ca4d752)
cwperks added a commit that referenced this pull request Mar 17, 2023
Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit ca4d752)

Co-authored-by: Craig Perkins <[email protected]>
peternied pushed a commit that referenced this pull request Mar 19, 2023
Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit ca4d752)

Co-authored-by: Craig Perkins <[email protected]>
peternied pushed a commit that referenced this pull request Mar 21, 2023
Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit ca4d752)

Co-authored-by: Craig Perkins <[email protected]>
MaciejMierzwa pushed a commit to MaciejMierzwa/security that referenced this pull request Apr 20, 2023
MaciejMierzwa pushed a commit to MaciejMierzwa/security that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x backport to 1.x branch backport 1.3 backport to 1.3 branch backport 2.x backport to 2.x branch backport 2.6 backport to 2.6 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants