[CVE-2023-23612] Remove trimming of whitespace when extracting SAML backend roles #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2381 +/- ##
============================================
- Coverage 61.10% 61.05% -0.05%
+ Complexity 3273 3269 -4
============================================
Files 260 260
Lines 18364 18362 -2
Branches 3250 3249 -1
============================================
- Hits 11221 11211 -10
- Misses 5558 5562 +4
- Partials 1585 1589 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
peternied
approved these changes
Jan 6, 2023
RyanL1997
approved these changes
Jan 6, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 6, 2023
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 8ee28d1)
peternied
pushed a commit
that referenced
this pull request
Jan 6, 2023
…) (#2383) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 8ee28d1)
|
@cwperks Should this be backported to 1.x -> 1.3? |
peternied
changed the title
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
…nsearch-project#2381) (opensearch-project#2383) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 8ee28d1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OpenSearch uses JWTs to store role claims obtained from the Identity Provider (IdP) when the authentication backend is SAML or OpenID Connect. There is an issue in how those claims are processed from the JWTs where the leading and trailing whitespace is trimmed, allowing users to potentially claim roles they are not assigned to if any role matches the whitespace-stripped version of the roles they are a member of.
This pull request remove trimming of whitespace when extracting SAML backend roles.
Testing
New unit test has been added to verify the functionality
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.