[CVE-2023-23613] When excluding fields also exclude the term + .keyword
#2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Nied <[email protected]>
cwperks
approved these changes
Jan 5, 2023
| @@ -142,6 +142,7 @@ class DlsFlsFilterLeafReader extends SequentialStoredFieldsLeafReader { | |||
|
|
|||
| if (firstChar == '!' || firstChar == '~') { | |||
| excludesSet.add(incExc.substring(1)); | |||
| excludesSet.add(incExc.substring(1) + KEYWORD); | |||
There was a problem hiding this comment.
For my knowledge: What would this change accomplish?
There was a problem hiding this comment.
When documents are parsed fields are mapped to types, for string mappings a keyword field is automatically created. By additional excluding keyword fields if you wanted to block a field actors, we would also block actors.keyword to ensure those field values are not included in queries.
DarshitChanpura
approved these changes
Jan 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 5, 2023
Signed-off-by: Peter Nied <[email protected]> (cherry picked from commit 1ec875c)
peternied
changed the title
.keyword.keyword
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is an issue in the implementation of field-level security (FLS) and field masking where rules written to explicitly exclude fields are not correctly applied for certain queries that rely on their auto-generated .keyword fields.
When excluding fields also exclude the term +
.keywordCheck List
New functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.