-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script for workflow version increment #2374
Add script for workflow version increment #2374
Conversation
Signed-off-by: Ryan Liang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2374 +/- ##
============================================
- Coverage 61.09% 61.03% -0.07%
+ Complexity 3271 3268 -3
============================================
Files 260 260
Lines 18363 18363
Branches 3250 3250
============================================
- Hits 11219 11207 -12
- Misses 5559 5566 +7
- Partials 1585 1590 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
@RyanL1997 Is it possible to accomplish the same version increment automation by adding |
Hi @cwperks, thanks for the comment! I was actually thinking the same yesterday and I found that this line (https://github.com/opensearch-project/security/blob/main/build.gradle#L643) is doing the matching and replacing. It seems like this the content is not the one we want, so I think we may need another |
@cwperks Can you please merge this once your comment has been resolved? |
@RyanL1997 How did you test the change? When I add the file into the existing section and run
I get the same output when running the change in this PR. The difference is that the first block removes |
Signed-off-by: Ryan Liang <[email protected]>
e81979f
Hi @cwperks, I have updated this and add the workflow directory to the original |
* Add script for workflow version increment Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit be7beb9)
* Add script for workflow version increment Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit be7beb9)
* Add script for workflow version increment Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit be7beb9)
* Add script for workflow version increment Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit be7beb9)
…pensearch-project#2386) * Add script for workflow version increment Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit be7beb9)
Signed-off-by: Ryan Liang [email protected]
Description
Add script for workflow version increment
Issues Resolved
Is this a backport? If so, please add backport PR # and/or commits #
2.x, 2.4
Check List
New functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.