Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports sanity tests to 1.x #2355

Conversation

DarshitChanpura
Copy link
Member

@DarshitChanpura DarshitChanpura commented Dec 15, 2022

Backports #1958 manually.

Resolves #2398

Check List

- [ ] New functionality includes testing
- [ ] New functionality has been documented

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@DarshitChanpura DarshitChanpura requested a review from a team December 15, 2022 17:18
@DarshitChanpura DarshitChanpura force-pushed the backport/backport-1958-to-1.x branch from 996bf41 to 1389b4e Compare December 16, 2022 18:37
Signed-off-by: Darshit Chanpura <[email protected]>
@DarshitChanpura DarshitChanpura force-pushed the backport/backport-1958-to-1.x branch from 1389b4e to 4a8971e Compare December 16, 2022 22:10
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we can't just backport this PR, the build.gradle scripts were completely rewritten [1] in 2.0 to fix these issues you are encountering during the build.

Could you see if there a way we can remove the gradle related components of the test so we can minimize build script changes?

@peternied
Copy link
Member

@DarshitChanpura any thoughts on where we go from here?

@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Jan 9, 2023

@DarshitChanpura any thoughts on where we go from here?

I'll convert this to draft for now until I have significant update, as this requires more change than a simple gradle fix.

@DarshitChanpura DarshitChanpura marked this pull request as draft January 9, 2023 21:00
@peternied
Copy link
Member

Unless you are actively working on this I'd recommend we covert this to an issue

@DarshitChanpura
Copy link
Member Author

Unless you are actively working on this I'd recommend we covert this to an issue

Done. I will close this PR for now and will re-open once I resume work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants