[Backport 2.3] Username validation for special characters (#2277)

[rutuja-amazon]

Description

Username validation for special characters (#2277)

• Only prevent user creation on colon characters, separate out tests

Signed-off-by: Rutuja Surve [email protected]
Signed-off-by: Rutuja Surve [email protected]
Signed-off-by: Peter Nied [email protected]
Co-authored-by: Peter Nied [email protected] (cherry picked from commit efbc48b)

[codecov-commenter]

Codecov Report

Merging #2333 (6010ac4) into 2.3 (c23950d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                2.3    #2333   +/-   ##
=========================================
  Coverage     61.02%   61.02%           
- Complexity     3228     3229    +1     
=========================================
  Files           256      256           
  Lines         18075    18081    +6     
  Branches       3225     3226    +1     
=========================================
+ Hits          11030    11034    +4     
- Misses         5467     5468    +1     
- Partials       1578     1579    +1     

Impacted Files	Coverage Δ
...security/dlic/rest/api/InternalUsersApiAction.java	83.78% <100.00%> (+1.43%)	⬆️
...ecurity/configuration/ConfigurationRepository.java	72.13% <0.00%> (-2.19%)	⬇️
...a/org/opensearch/security/tools/SecurityAdmin.java	35.75% <0.00%> (-0.25%)	⬇️
...nsearch/security/dlic/rest/api/AuditApiAction.java	68.08% <0.00%> (+4.25%)	⬆️
...ecurity/configuration/StaticResourceException.java	25.00% <0.00%> (+25.00%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.