Remove jackson-databind and jackson-annotations dependency now coming from core #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
|
CI won't pass until new artifacts are available for core. The distribution build for 3.0.0 has not succeeded since November 15. |
RyanL1997
reviewed
Dec 12, 2022
Can you create an issue on this? |
….apache.kafka:kafka-storage Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2325 +/- ##
============================================
- Coverage 61.09% 61.03% -0.06%
+ Complexity 3271 3267 -4
============================================
Files 260 260
Lines 18363 18369 +6
Branches 3250 3251 +1
============================================
- Hits 11219 11212 -7
- Misses 5559 5566 +7
- Partials 1585 1591 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Craig Perkins <[email protected]>
peternied
approved these changes
Dec 12, 2022
DarshitChanpura
approved these changes
Dec 13, 2022
This was referenced Dec 13, 2022
This was referenced Dec 13, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 13, 2022
… from core (#2325) * Remove jackson-databind dependency now coming from core Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit ff798dd)
3 tasks
cwperks
pushed a commit
that referenced
this pull request
Dec 21, 2022
… from core (#2325) (#2343) * Remove jackson-databind dependency now coming from core Signed-off-by: Craig Perkins <[email protected]>
3 tasks
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
… from core (opensearch-project#2325) (opensearch-project#2343) * Remove jackson-databind dependency now coming from core Signed-off-by: Craig Perkins <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Craig Perkins [email protected]
Description
jackson-databind and jackson-annotations were added as api dependencies in
serverof opensearch core. The security plugin now gets these dependencies transitively and does not need direct dependencies on the jars.PR in core where the dependencies are added: opensearch-project/OpenSearch#5366
Maintenance
Issues Resolved
#2324
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.