Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.4] Username validation for special characters #2322

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport efbc48b from #2277

* Only prevent user creation on colon characters, separate out tests

Signed-off-by: Rutuja Surve <[email protected]>
Signed-off-by: Rutuja Surve <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Co-authored-by: Peter Nied <[email protected]>
(cherry picked from commit efbc48b)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team December 9, 2022 21:50
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Merging #2322 (c4c17ed) into 2.4 (ad3656c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.4    #2322      +/-   ##
============================================
+ Coverage     61.07%   61.10%   +0.03%     
- Complexity     3250     3253       +3     
============================================
  Files           258      258              
  Lines         18125    18131       +6     
  Branches       3231     3232       +1     
============================================
+ Hits          11069    11079      +10     
+ Misses         5485     5482       -3     
+ Partials       1571     1570       -1     
Impacted Files Coverage Δ
...security/dlic/rest/api/InternalUsersApiAction.java 83.78% <100.00%> (+1.43%) ⬆️
...ch/security/auditlog/routing/AsyncStoragePool.java 50.00% <0.00%> (-5.56%) ⬇️
...a/org/opensearch/security/tools/SecurityAdmin.java 36.00% <0.00%> (+0.24%) ⬆️
...nsearch/security/dlic/rest/api/AuditApiAction.java 68.08% <0.00%> (+4.25%) ⬆️
...ecurity/configuration/StaticResourceException.java 25.00% <0.00%> (+25.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternied peternied merged commit 07802ac into 2.4 Dec 9, 2022
@peternied peternied deleted the backport/backport-2277-to-2.4 branch December 9, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants