Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Username validation for special characters #2317

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport efbc48b from #2277

* Only prevent user creation on colon characters, separate out tests

Signed-off-by: Rutuja Surve <[email protected]>
Signed-off-by: Rutuja Surve <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Co-authored-by: Peter Nied <[email protected]>
(cherry picked from commit efbc48b)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team December 9, 2022 21:12
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Merging #2317 (efbc48b) into 2.x (b7bf4a2) will increase coverage by 0.03%.
The diff coverage is 77.77%.

❗ Current head efbc48b differs from pull request most recent head 66823a2. Consider uploading reports for the commit 66823a2 to get more accurate results

@@             Coverage Diff              @@
##                2.x    #2317      +/-   ##
============================================
+ Coverage     61.04%   61.08%   +0.03%     
- Complexity     3248     3270      +22     
============================================
  Files           258      260       +2     
  Lines         18125    18369     +244     
  Branches       3231     3251      +20     
============================================
+ Hits          11065    11220     +155     
- Misses         5490     5562      +72     
- Partials       1570     1587      +17     
Impacted Files Coverage Δ
...ic/auth/http/jwt/AbstractHTTPJwtAuthenticator.java 55.81% <ø> (ø)
...mazon/dlic/auth/http/jwt/HTTPJwtAuthenticator.java 85.71% <ø> (ø)
...ic/auth/http/kerberos/HTTPSpnegoAuthenticator.java 0.00% <0.00%> (ø)
...dlic/auth/http/saml/AuthTokenProcessorHandler.java 47.28% <0.00%> (ø)
...auth/http/saml/SamlFilesystemMetadataResolver.java 0.00% <0.00%> (ø)
...tion/configupdate/TransportConfigUpdateAction.java 100.00% <ø> (ø)
...security/auditlog/sink/ExternalOpenSearchSink.java 59.25% <0.00%> (ø)
...security/configuration/DlsFlsFilterLeafReader.java 61.98% <ø> (ø)
...search/security/configuration/DlsFlsValveImpl.java 59.47% <ø> (ø)
...earch/security/dlic/rest/api/MigrateApiAction.java 4.34% <ø> (+0.18%) ⬆️
... and 76 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternied peternied merged commit db02f6a into 2.x Dec 9, 2022
@peternied peternied deleted the backport/backport-2277-to-2.x branch December 9, 2022 23:25
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
…pensearch-project#2317)

* Only prevent user creation on colon characters, separate out tests

Signed-off-by: Rutuja Surve <[email protected]>
Signed-off-by: Rutuja Surve <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Co-authored-by: Peter Nied <[email protected]>
(cherry picked from commit efbc48b)

Co-authored-by: rutuja-amazon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants