Integrate k-NN functionality with security plugin #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds k-NN read only and full access roles to the default roles file. Signed-off-by: John Mazanec <[email protected]>
Adds k-NN model index to demo for system index. Signed-off-by: John Mazanec <[email protected]>
peternied
approved these changes
Nov 28, 2022
DarshitChanpura
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
LGTM! @jmazanec15 if there is nothing more to be added from your end, can you please mark this as ready for review so that this can be merged
|
@peternied @DarshitChanpura Ready for review! |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
Adds k-NN read only and full access roles to the default roles file. Adds k-NN model index to demo for system index. Signed-off-by: John Mazanec <[email protected]> (cherry picked from commit e7a120c)
cwperks
added a commit
that referenced
this pull request
Feb 21, 2023
Adds k-NN read only and full access roles to the default roles file. Adds k-NN model index to demo for system index. Signed-off-by: John Mazanec <[email protected]> (cherry picked from commit e7a120c) Co-authored-by: John Mazanec <[email protected]> Co-authored-by: Craig Perkins <[email protected]>
jmazanec15
added a commit
to jmazanec15/security
that referenced
this pull request
Feb 24, 2023
…-project#2274) (opensearch-project#2455)" This reverts commit 6ded82d. Signed-off-by: John Mazanec <[email protected]>
peternied
added a commit
that referenced
this pull request
Feb 24, 2023
peternied
added a commit
that referenced
this pull request
Feb 24, 2023
)" This reverts commit 6ded82d. Resolves #2478 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]>
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
…#2274) (opensearch-project#2455) Adds k-NN read only and full access roles to the default roles file. Adds k-NN model index to demo for system index. Signed-off-by: John Mazanec <[email protected]> (cherry picked from commit e7a120c) Co-authored-by: John Mazanec <[email protected]> Co-authored-by: Craig Perkins <[email protected]>
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
…-project#2274) (opensearch-project#2455)" This reverts commit 6ded82d. Resolves opensearch-project#2478 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds 2 k-NN related roles to the plugin: read only and fully access.
Adds k-NN system index to demo scripts as well.
Issues Resolved
#2265
Testing
Pending
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.