-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize Backwards Compatibility tests so we can test from any version to any version #2253
Conversation
e75a9c2
to
d2efd08
Compare
The build is totally broken because a JDK18 features is being used - waiting on the following issue to be merged to resolve this |
Codecov Report
@@ Coverage Diff @@
## main #2253 +/- ##
============================================
+ Coverage 61.02% 61.12% +0.09%
- Complexity 3267 3271 +4
============================================
Files 259 259
Lines 18337 18337
Branches 3248 3248
============================================
+ Hits 11191 11209 +18
+ Misses 5561 5541 -20
- Partials 1585 1587 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…ion to any version With an issue reported indicating that there are serialization issue between 1.3 and 2.X, making sure that we can reproduce the errors. This new workflow(s) will make sure that we aren't breaking BWC with changes we are adding to 2.X and will give us the flexibility to test certain migration workflows. Fixing an issue where the BWC tests were not actually building or executing causing the clusters to spin up and then immediately spin down. We will need to invest more energy into running multiple kinds of security plugin specific scenarios through the test system. Signed-off-by: Peter Nied <[email protected]>
d2efd08
to
aca655b
Compare
Note; CI is blocked until the following issue(s) are resolved: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @peternied! I took a first pass and really like the flexibility this gives us in BWC testing. Left a few thoughts. There's a few descriptions that look incomplete which should be addressed, but otherwise this looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much cleaner and compartmentalized!!
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
@cwperks @DarshitChanpura @scrawfor99 CI has finally been sorted out since we've got a 2.5.0 build, please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty @peternied for resolving this pain!
@peternied Quick q: Is it safe to ignore these Windows errors? |
@cwperks Interesting, since they are falling back seems safe to me. Took a look at the related code, seems like maybe its slowing the process down a little. I think we could dig in more in the future if we were looking for a speed boost |
This looks really good to me! |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-2253-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dc7d21c716250001926af9ce5d5937d221122ff9
# Push it to GitHub
git push --set-upstream origin backport/backport-2253-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3 Then, create a pull request where the |
…ion to any version (opensearch-project#2253) * Generalize Backwards Compatibility tests so we can test from any version to any version With an issue reported indicating that there are serialization issue between 1.3 and 2.X, making sure that we can reproduce the errors. This new workflow(s) will make sure that we aren't breaking BWC with changes we are adding to 2.X and will give us the flexibility to test certain migration workflows. Fixing an issue where the BWC tests were not actually building or executing causing the clusters to spin up and then immediately spin down. We will need to invest more energy into running multiple kinds of security plugin specific scenarios through the test system. Signed-off-by: Peter Nied <[email protected]>
Issue: - In versions between 1.1 and 2.10, the task :adBwcCluster#twoThirdsUpgradedClusterTask fails. - Symptoms mirror those in [OpenSearch Issue #5076](opensearch-project/OpenSearch#5076). - Logs show nodes from old and new versions failing to join as a cluster, resulting in a "master not found" exception. Resolution: - Upgraded the bwc version to 1.3.2, aligning with other plugins which use 1.3+ as their baseline. - [Cross-Cluster Replication PR opensearch-project#469](opensearch-project/cross-cluster-replication#469) - [Security PR #2253](opensearch-project/security#2253) - [ML Commons PR opensearch-project#681](opensearch-project/ml-commons#681) - Post-upgrade, the twoThirdsUpgradedClusterTask runs successfully, suggesting potential incompatibility between versions 1.1 and 2.10. Testing: - Executed `./gradlew bwcTestSuite -Dtests.security.manager=false` and all tests passed. Signed-off-by: Kaituo Li <[email protected]>
Issue: - In versions between 1.1 and 2.10, the task :adBwcCluster#twoThirdsUpgradedClusterTask fails. - Symptoms mirror those in [OpenSearch Issue #5076](opensearch-project/OpenSearch#5076). - Logs show nodes from old and new versions failing to join as a cluster, resulting in a "master not found" exception. Resolution: - Upgraded the bwc version to 1.3.2, aligning with other plugins which use 1.3+ as their baseline. - [Cross-Cluster Replication PR opensearch-project#469](opensearch-project/cross-cluster-replication#469) - [Security PR #2253](opensearch-project/security#2253) - [ML Commons PR opensearch-project#681](opensearch-project/ml-commons#681) - Post-upgrade, the twoThirdsUpgradedClusterTask runs successfully, suggesting potential incompatibility between versions 1.1 and 2.10. Testing: - Executed `./gradlew bwcTestSuite -Dtests.security.manager=false` and all tests passed. Signed-off-by: Kaituo Li <[email protected]>
…sue (#1029) Issue: - In versions between 1.1 and 2.10, the task :adBwcCluster#twoThirdsUpgradedClusterTask fails. - Symptoms mirror those in [OpenSearch Issue #5076](opensearch-project/OpenSearch#5076). - Logs show nodes from old and new versions failing to join as a cluster, resulting in a "master not found" exception. Resolution: - Upgraded the bwc version to 1.3.2, aligning with other plugins which use 1.3+ as their baseline. - [Cross-Cluster Replication PR #469](opensearch-project/cross-cluster-replication#469) - [Security PR #2253](opensearch-project/security#2253) - [ML Commons PR #681](opensearch-project/ml-commons#681) - Post-upgrade, the twoThirdsUpgradedClusterTask runs successfully, suggesting potential incompatibility between versions 1.1 and 2.10. Testing: - Executed `./gradlew bwcTestSuite -Dtests.security.manager=false` and all tests passed. Signed-off-by: Kaituo Li <[email protected]>
…sue (#1029) Issue: - In versions between 1.1 and 2.10, the task :adBwcCluster#twoThirdsUpgradedClusterTask fails. - Symptoms mirror those in [OpenSearch Issue #5076](opensearch-project/OpenSearch#5076). - Logs show nodes from old and new versions failing to join as a cluster, resulting in a "master not found" exception. Resolution: - Upgraded the bwc version to 1.3.2, aligning with other plugins which use 1.3+ as their baseline. - [Cross-Cluster Replication PR #469](opensearch-project/cross-cluster-replication#469) - [Security PR #2253](opensearch-project/security#2253) - [ML Commons PR #681](opensearch-project/ml-commons#681) - Post-upgrade, the twoThirdsUpgradedClusterTask runs successfully, suggesting potential incompatibility between versions 1.1 and 2.10. Testing: - Executed `./gradlew bwcTestSuite -Dtests.security.manager=false` and all tests passed. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit 3c1a830)
…sue (#1029) (#1030) Issue: - In versions between 1.1 and 2.10, the task :adBwcCluster#twoThirdsUpgradedClusterTask fails. - Symptoms mirror those in [OpenSearch Issue #5076](opensearch-project/OpenSearch#5076). - Logs show nodes from old and new versions failing to join as a cluster, resulting in a "master not found" exception. Resolution: - Upgraded the bwc version to 1.3.2, aligning with other plugins which use 1.3+ as their baseline. - [Cross-Cluster Replication PR #469](opensearch-project/cross-cluster-replication#469) - [Security PR #2253](opensearch-project/security#2253) - [ML Commons PR #681](opensearch-project/ml-commons#681) - Post-upgrade, the twoThirdsUpgradedClusterTask runs successfully, suggesting potential incompatibility between versions 1.1 and 2.10. Testing: - Executed `./gradlew bwcTestSuite -Dtests.security.manager=false` and all tests passed. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit 3c1a830) Co-authored-by: Kaituo Li <[email protected]>
Description
With an issue reported indicating that there are serialization issue between 1.3 and 2.X, making sure that we can reproduce the errors. This new workflow(s) will make sure that we aren't breaking BWC with changes we are adding to 2.X and will give us the flexibility to test certain migration workflows.
Fixing an issue where the BWC tests were not actually building or executing causing the clusters to spin up and then immediately spin down. We will need to invest more energy into running multiple kinds of security plugin specific scenarios through the test system.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.