TLS related tests. #2156
Merged
TLS related tests. #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternied
reviewed
Oct 12, 2022
lukasz-soszynski-eliatra
force-pushed
the
tls-tests
branch
from
00a8b36 to
4b40174
Compare
peternied
previously approved these changes
Oct 13, 2022
| import org.apache.http.impl.client.HttpClientBuilder; | ||
| import org.apache.http.impl.client.HttpClients; | ||
|
|
||
| class CloseableHttpClientFactory { |
lukasz-soszynski-eliatra
force-pushed
the
tls-tests
branch
from
4b40174 to
0a49c5d
Compare
Signed-off-by: Lukasz Soszynski <[email protected]>
Signed-off-by: Lukasz Soszynski <[email protected]>
lukasz-soszynski-eliatra
force-pushed
the
tls-tests
branch
from
0a49c5d to
f0f675b
Compare
peternied
approved these changes
Oct 19, 2022
cwperks
approved these changes
Oct 21, 2022
stephen-crawford
pushed a commit
to stephen-crawford/security
that referenced
this pull request
Nov 10, 2022
This PR introduced negative test cases related to TLS. Almost all integration tests use TLS so this feature is already pretty well tested. Signed-off-by: Lukasz Soszynski <[email protected]> Signed-off-by: Lukasz Soszynski <[email protected]> Signed-off-by: Stephen Crawford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lukasz Soszynski [email protected]
Description
[Describe what this change achieves]
Almost all integration tests use TLS so this feature is already pretty well tested. This PR introduced negative test cases related to TLS. Some extensions related to audit logs are required but can be introduced when another PR #2153 is merged.
Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.