Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.3] Update Kafka Client to 3.0.2 #2129

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

vinayak15
Copy link
Contributor

@vinayak15 vinayak15 commented Sep 29, 2022

Description

[Describe what this change achieves]
Update Kafka version to fix security vulnerability(#2095)

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vinayak Kothari <[email protected]>
@vinayak15 vinayak15 requested a review from a team September 29, 2022 20:54
@vinayak15 vinayak15 changed the title Update Kafka Client to 3.0.2 [1.3] Update Kafka Client to 3.0.2 Sep 29, 2022
@peternied peternied changed the base branch from 1.3 to main September 29, 2022 21:15
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this change off of main. We accept changes to main and then backport them as needed to branches like 1.3, and I think this should follow the standard process.

@cwperks
Copy link
Member

cwperks commented Sep 29, 2022

@peternied This is a manual backport to 1.3. The backport bot failed for 1.3. See #2123.

@peternied peternied changed the base branch from main to 1.3 September 29, 2022 21:19
@peternied peternied changed the title [1.3] Update Kafka Client to 3.0.2 [Backport 1.3] Update Kafka Client to 3.0.2 Sep 29, 2022
@peternied
Copy link
Member

Thanks for noticing it was a backport @cwperks I've changed the branch back to 1.3 and as soon as CI finishes we can merge this change (it only requires 1 approver)

@codecov-commenter
Copy link

Codecov Report

Merging #2129 (e2e0ada) into 1.3 (e18485d) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.3    #2129      +/-   ##
============================================
- Coverage     64.61%   64.43%   -0.18%     
+ Complexity     3217     3216       -1     
============================================
  Files           247      247              
  Lines         17349    17341       -8     
  Branches       3078     3073       -5     
============================================
- Hits          11210    11174      -36     
- Misses         4583     4617      +34     
+ Partials       1556     1550       -6     
Impacted Files Coverage Δ
...ava/com/amazon/dlic/auth/ldap2/MakeJava9Happy.java 8.69% <0.00%> (-30.44%) ⬇️
...ecurity/configuration/StaticResourceException.java 0.00% <0.00%> (-25.00%) ⬇️
...security/auditlog/sink/InternalOpenSearchSink.java 72.00% <0.00%> (-8.77%) ⬇️
...com/amazon/dlic/auth/ldap2/PrivilegedProvider.java 44.26% <0.00%> (-4.92%) ⬇️
...nsearch/security/dlic/rest/api/AuditApiAction.java 63.82% <0.00%> (-4.26%) ⬇️
...ic/auth/ldap/backend/LDAPAuthorizationBackend.java 53.59% <0.00%> (-3.98%) ⬇️
...dlic/auth/http/saml/AuthTokenProcessorHandler.java 46.99% <0.00%> (-0.29%) ⬇️
...ch/security/securityconf/DynamicConfigFactory.java 60.92% <0.00%> (-0.26%) ⬇️
...earch/security/resolver/IndexResolverReplacer.java 63.87% <0.00%> (-0.11%) ⬇️
.../org/opensearch/security/support/ConfigHelper.java 80.39% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternied
Copy link
Member

peternied commented Sep 29, 2022

I am merging anyways, tests in the 1.3 have many known issues that were fixed in future versions.

@peternied peternied merged commit d8179c9 into opensearch-project:1.3 Sep 29, 2022
@vinayak15 vinayak15 deleted the upgrade-kafka-on-1.3 branch October 3, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants