Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3] Updates jackson version to be in sync with core #2128

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

DarshitChanpura
Copy link
Member

Issues Resolved

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@DarshitChanpura DarshitChanpura added the backport 1.3 backport to 1.3 branch label Sep 29, 2022
@DarshitChanpura DarshitChanpura requested a review from a team September 29, 2022 20:40
@DarshitChanpura DarshitChanpura changed the title Updates jackson version to be in sync with core [1.x] Updates jackson version to be in sync with core Sep 29, 2022
cwperks
cwperks previously approved these changes Sep 29, 2022
@peternied peternied changed the base branch from 1.x to 1.3 September 29, 2022 21:16
@peternied peternied dismissed cwperks’s stale review September 29, 2022 21:16

The base branch was changed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022

Codecov Report

Merging #2128 (04ee420) into 1.3 (9bf0ab8) will increase coverage by 0.03%.
The diff coverage is 58.33%.

@@             Coverage Diff              @@
##                1.3    #2128      +/-   ##
============================================
+ Coverage     64.59%   64.63%   +0.03%     
- Complexity     3215     3217       +2     
============================================
  Files           247      247              
  Lines         17351    17358       +7     
  Branches       3082     3085       +3     
============================================
+ Hits          11208    11219      +11     
+ Misses         4594     4591       -3     
+ Partials       1549     1548       -1     
Impacted Files Coverage Δ
...earch/security/resolver/IndexResolverReplacer.java 63.97% <54.54%> (+0.34%) ⬆️
...earch/security/privileges/PrivilegesEvaluator.java 71.57% <100.00%> (+0.09%) ⬆️
...search/security/transport/SecurityInterceptor.java 73.94% <0.00%> (-0.85%) ⬇️
...earch/security/ssl/util/SSLConnectionTestUtil.java 95.45% <0.00%> (+2.27%) ⬆️
...urity/ssl/transport/SecuritySSLNettyTransport.java 73.40% <0.00%> (+4.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't update 1.x, its a dead end branch. Can this change be pointed against main and backported? If not, please make the change against 1.3

@cwperks
Copy link
Member

cwperks commented Sep 30, 2022

@DarshitChanpura Please re-base this change against 1.3. This change will be included in 1.3.6 and needs to get merged in today as EOD today is code freeze for 1.3.6.

@DarshitChanpura DarshitChanpura changed the title [1.x] Updates jackson version to be in sync with core [1.3] Updates jackson version to be in sync with core Sep 30, 2022
@cwperks cwperks removed the backport 1.3 backport to 1.3 branch label Sep 30, 2022
@peternied
Copy link
Member

Retriggering CI

@peternied peternied merged commit a3ff007 into opensearch-project:1.3 Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants