Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope updateVersion to only build.gradle in 1.3 #2121

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Sep 29, 2022

Signed-off-by: Craig Perkins [email protected]

Description

The last version increment automation to run against 1.3 picked up all files of the project since it did not include an explicit include directive in the block. These lines are not needed in this branch since the only reference to the version is in build.gradle.

See relevant conversation on this PR: #2119

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Bug fix

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks cwperks requested a review from a team September 29, 2022 14:51
@cwperks cwperks changed the title Remove extraneous lines in updateVersion to update version outside of… Scope updateVersion to only build.gradle in 1.3 Sep 29, 2022
Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@codecov-commenter
Copy link

Codecov Report

Merging #2121 (8a36a85) into 1.3 (6b32c47) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                1.3    #2121   +/-   ##
=========================================
  Coverage     64.66%   64.66%           
- Complexity     3217     3218    +1     
=========================================
  Files           247      247           
  Lines         17350    17350           
  Branches       3087     3087           
=========================================
+ Hits          11219    11220    +1     
  Misses         4582     4582           
+ Partials       1549     1548    -1     
Impacted Files Coverage Δ
...search/security/transport/SecurityInterceptor.java 74.78% <0.00%> (+0.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cwperks cwperks merged commit e18485d into opensearch-project:1.3 Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants